Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dataspace-protocol: split CN and TP Services #2681

Closed
Tracked by #2429
ndr-brt opened this issue Apr 5, 2023 · 0 comments · Fixed by #2689
Closed
Tracked by #2429

dataspace-protocol: split CN and TP Services #2681

ndr-brt opened this issue Apr 5, 2023 · 0 comments · Fixed by #2689
Assignees
Labels
dataspace-protocol related to the dataspace protocol refactoring Cleaning up code and dependencies
Milestone

Comments

@ndr-brt
Copy link
Member

ndr-brt commented Apr 5, 2023

Feature Request

Currently all the "client" and the "protocol" logic stays in the ContractNegotiationService and in the TransferProcessService.
Those could be split in:

  • *Service: is meant to contain the logic called internally or by some clients
  • *ProtocolService: contains all the logic that need to be executed after receiving a protocol message

Which Areas Would Be Affected?

contract negotiation, transfer process

Why Is the Feature Desired?

cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dataspace-protocol related to the dataspace protocol refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant