Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spi modules should not rely on core ones #2033

Closed
Tracked by #1596
ndr-brt opened this issue Sep 29, 2022 · 1 comment · Fixed by #2098
Closed
Tracked by #1596

spi modules should not rely on core ones #2033

ndr-brt opened this issue Sep 29, 2022 · 1 comment · Fixed by #2098
Labels
refactoring Cleaning up code and dependencies
Milestone

Comments

@ndr-brt
Copy link
Member

ndr-brt commented Sep 29, 2022

Feature Request

Actually there are some spi that have on their dependencies some core modules. This shouldn't happen:
(output of ag ":core:" spi, ag is the_silver_searcher)

spi/common/core-spi/build.gradle.kts
37:    implementation(project(":core:common:util"))

spi/data-plane/data-plane-spi/build.gradle.kts
24:    implementation(project(":core:common:util"))

spi/data-plane-selector/data-plane-selector-spi/build.gradle.kts
22:    implementation(project(":core:common:util"))

spi/control-plane/transfer-spi/build.gradle.kts
30:    api(project(":core:common:policy-evaluator"))

Which Areas Would Be Affected?

spi

Why Is the Feature Desired?

untangle dependencies

Type of Issue

@ndr-brt ndr-brt added the refactoring Cleaning up code and dependencies label Sep 29, 2022
@ndr-brt ndr-brt mentioned this issue Sep 29, 2022
18 tasks
@github-actions
Copy link

This issue is stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale Open for x days with no activity label Oct 14, 2022
@ndr-brt ndr-brt removed the stale Open for x days with no activity label Oct 14, 2022
@ndr-brt ndr-brt added this to the Milestone 7 milestone Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Cleaning up code and dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant