Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Connector not starting, OAuth2Extension cannot resolve certificates #1892

Closed
DominikPinsel opened this issue Aug 26, 2022 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@DominikPinsel
Copy link
Contributor

Bug Report

Describe the Bug

When starting the EDC the OAuth2Extension.getEncodedClientCertificate always throws an org.eclipse.dataspaceconnector.spi.EdcException: Public certificate not found exception.

Expected Behavior

  • Connector starting and resolving certificates from vault

Observed Behavior

  • Connector not starting

Steps to Reproduce

Steps to reproduce the behavior:

  1. Start IDS Connector

Context Information

Add any other context about the problem here.

  • Used version 0.0.1-20220818-SNAPSHOT

Detailed Description

  • Extension is always using the NoopCertificateResolver

Possible Implementation

  • Probably the DefaultCertificateResolver should be used instead

Dominik Pinsel [email protected], Mercedes-Benz Tech Innovation GmbH, legal info/Impressum

@DominikPinsel DominikPinsel added the bug Something isn't working label Aug 26, 2022
@ndr-brt
Copy link
Member

ndr-brt commented Aug 27, 2022

If you use a vault custom extension you need to explicitly register the VaultCertificateResolver.
For an example, look at the hashicorp-vault extension:
https://github.com/eclipse-dataspaceconnector/DataSpaceConnector/blob/main/extensions/common/vault/hashicorp-vault/src/main/java/org/eclipse/dataspaceconnector/core/security/hashicorpvault/HashicorpVaultExtension.java#L75

@DominikPinsel
Copy link
Contributor Author

If you use a vault custom extension you need to explicitly register the VaultCertificateResolver.
For an example, look at the hashicorp-vault extension:
https://github.com/eclipse-dataspaceconnector/DataSpaceConnector/blob/main/extensions/common/vault/hashicorp-vault/src/main/java/org/eclipse/dataspaceconnector/core/security/hashicorpvault/HashicorpVaultExtension.java#L75

With our custom extension everything works fine. Our problem occurs with the Azure Vault extension from this repository, but I assume the HashiCorp vault extension from this repository has this problem, too.
But I just saw that you fixed this issue 7 days ago in PR #1842 -> will close this issue.

Dominik Pinsel [email protected], Mercedes-Benz Tech Innovation GmbH, legal info/Impressum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants