Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContractDefinitionService interface exists twice #1248

Closed
2 tasks done
Tracked by #1596
DominikPinsel opened this issue May 3, 2022 · 5 comments · Fixed by #2113
Closed
2 tasks done
Tracked by #1596

ContractDefinitionService interface exists twice #1248

DominikPinsel opened this issue May 3, 2022 · 5 comments · Fixed by #2113
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@DominikPinsel
Copy link
Contributor

Feature Request

Currently there are two different kind of interfaces for a ContractDefinitionService. I would suggest to rename one,
They are implemented in the following packages

  • org.eclipse.dataspaceconnector.api.datamanagement.contractdefinition.service
  • org.eclipse.dataspaceconnector.spi.contract.offer

Which Areas Would Be Affected?

Why Is the Feature Desired?

Avoid confusion in documentation and code.

Solution Proposal

Rename one ContractDefinitionService.

Type of Issue

Improvement / Cleanup

Checklist

  • assigned appropriate label?
  • Do NOT select a milestone or an assignee!

Dominik Pinsel [email protected], Mercedes-Benz Tech Innovation GmbH, legal info/Impressum

@DominikPinsel DominikPinsel added enhancement New feature or request no-changelog labels May 3, 2022
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

This issue is stale because it has been open for 28 days with no activity.

@github-actions github-actions bot added the stale Open for x days with no activity label Jun 7, 2022
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

This issue is stale because it has been open for 14 days with no activity.

@github-actions
Copy link

This issue was closed because it has been inactive for 7 days since being marked as stale.

@github-actions
Copy link

This issue was closed because it has been inactive for 7 days since being marked as stale.

@ndr-brt ndr-brt removed the stale Open for x days with no activity label Aug 25, 2022
@ndr-brt ndr-brt reopened this Aug 25, 2022
@ndr-brt ndr-brt added this to the Milestone 7 milestone Aug 25, 2022
@ndr-brt ndr-brt self-assigned this Aug 25, 2022
@ndr-brt ndr-brt mentioned this issue Aug 25, 2022
18 tasks
@ndr-brt
Copy link
Member

ndr-brt commented Sep 19, 2022

subsequent of #1887

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants