Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests: replace fake implementations with mocks #1063

Closed
Tracked by #1596
ronjaquensel opened this issue Apr 4, 2022 · 4 comments · Fixed by #2011
Closed
Tracked by #1596

Tests: replace fake implementations with mocks #1063

ronjaquensel opened this issue Apr 4, 2022 · 4 comments · Fixed by #2011
Labels
good first issue Good for newcomers
Milestone
Backlog

Comments

@ronjaquensel
Copy link
Contributor

Some integration tests use fake implementations for interfaces (e.g. the FakeContractNegotiationStore in IdsApiMultipartEndpointV1IntegrationTestServiceExtension). Whenever methods are added to an interface, all fake implementations of that interface have to be adjusted as well.

Rather than using these fake implementations, mocks should be used in the integration tests. Thus, no changes to the test are required when new methods are added.
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

This issue is stale because it has been open for 28 days with no activity.

@github-actions github-actions bot added the stale Open for x days with no activity label Jun 7, 2022
@github-actions
Copy link

github-actions bot commented Jun 7, 2022

This issue is stale because it has been open for 14 days with no activity.

@github-actions
Copy link

This issue was closed because it has been inactive for 7 days since being marked as stale.

@github-actions
Copy link

This issue was closed because it has been inactive for 7 days since being marked as stale.

@ndr-brt ndr-brt removed the stale Open for x days with no activity label Aug 17, 2022
@ndr-brt ndr-brt reopened this Aug 17, 2022
@ndr-brt ndr-brt added this to the Backlog milestone Aug 17, 2022
@ndr-brt ndr-brt mentioned this issue Aug 17, 2022
Closed
18 tasks
@ndr-brt ndr-brt added the good first issue Good for newcomers label Sep 22, 2022
@ndr-brt ndr-brt mentioned this issue Sep 23, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

refactor: replace fakes with mocks Think-iT-Labs/edc-connector
2 participants
@ndr-brt @ronjaquensel