Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/compile config delay sending 226 #63

Commits on Nov 3, 2023

  1. Prevent PASV command from reporting signed numbers

    A signed-unsigned conversion was making the
    PASV command sometimes report signed numbers.
    This was detected by the Windows firewall as
    a problematice connection and it therefore
    terminated the connection.
    bjuulp committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    5a3c9fe View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Delay sending of code 226

    An FTP client implementation has been
    observed to close the data connection
    as soon as it receives the 226 status
    code - even though it hasn't received
    all data, yet. To improve interoper
    with such buggy clients, sending of
    the 226 status code can now be delayed
    a bit. The optional delay is controlled
    by means of preprocessor define that
    can be set from the cmake command
    line through a cmake cache variable.
    bjuulp committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    a5108c1 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Close data socket after file fetch

    The data socket is now also closed
    explicitly after file fetch in the
    case where sending of code 226 is
    not delayed.
    bjuulp committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    0df9596 View commit details
    Browse the repository at this point in the history
  2. Eliminate warning

    bjuulp committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    812558c View commit details
    Browse the repository at this point in the history