feat: Allow viewing content generated by AINSERT instruction and preprocessors #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavek-kucera
force-pushed
the
feat_virtual_files_support
branch
from
fcf6522 to
c322ed2
Compare
| @@ -419,11 +446,13 @@ void opencode_provider::convert_ainsert_buffer_to_copybook() | |||
| auto virtual_copy_name = | |||
| m_ctx->hlasm_ctx->ids().add("AINSERT:" + std::to_string(m_ctx->hlasm_ctx->obtain_ainsert_id())); | |||
|
|
|||
| auto new_file = m_virtual_files.try_emplace(virtual_copy_name, std::move(result)).first; | |||
| auto new_file = m_virtual_files.try_emplace(virtual_copy_name, std::move(result), next_virtual_file_id()).first; | |||
There was a problem hiding this comment.
It feels a little bit weird to deal with the virtual file IDs. Consider moving this responsibility somewhere else.
There was a problem hiding this comment.
I've actually realized that there is a much bigger (lifetime) issue, so I will rework this.
jirimosinger
approved these changes
Mar 29, 2022
slavek-kucera
force-pushed
the
feat_virtual_files_support
branch
from
74f2ac1 to
63c69a3
Compare
slavek-kucera
force-pushed
the
feat_virtual_files_support
branch
from
63c69a3 to
f234636
Compare
|
Kudos, SonarCloud Quality Gate passed! |
jirimosinger
approved these changes
Mar 30, 2022
|
🎉 This PR is included in version 1.2.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.