Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Literal support #207

Merged

Conversation

slavek-kucera
Copy link
Contributor

No description provided.

This was linked to issues Dec 1, 2021
@slavek-kucera slavek-kucera added the enhancement New feature or request label Dec 1, 2021
parser_library/src/parsing/grammar/machine_expr_rules.g4 Outdated Show resolved Hide resolved
parser_library/src/expressions/mach_expr_term.h Outdated Show resolved Hide resolved
parser_library/src/processing/op_code.cpp Outdated Show resolved Hide resolved
parser_library/test/processing/mach_instr_test.cpp Outdated Show resolved Hide resolved
ord_ctx.reserve_storage_area(size, no_align);

if (!cycle_ok)
diags.add_diagnostic(diagnostic_op::error_E033(it->second.r));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test this case?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am reasonably sure that this should never really happen, but not 100%.

@slavek-kucera slavek-kucera marked this pull request as ready for review December 3, 2021 18:12
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 8, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 69 Code Smells

88.4% 88.4% Coverage
0.0% 0.0% Duplication

@slavek-kucera slavek-kucera merged commit 44a93f2 into eclipse-che4z:development Dec 10, 2021
@slavek-kucera slavek-kucera deleted the feat_literal_support branch December 10, 2021 07:56
@zimlu02 zimlu02 added this to the 1.0.0 milestone Jan 13, 2022
@github-actions
Copy link

🎉 This PR is included in version 1.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symbols are not recognized inside literals Literals
3 participants