fix: Various fixes #166
Merged
fix: Various fixes #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… into mb/fix-apostrophe-lexing
This reverts commit 5653e1a.
| std::string input = R"( | ||
| DC CL1'' | ||
|
|
||
| CNOPSYM CNOP 0,8 |
There was a problem hiding this comment.
add a few more variants...
add also negative tests?
| stringer()); | ||
| } // namespace | ||
|
|
||
| TEST_P(parser_string_fixture, basic) |
There was a problem hiding this comment.
add also negative tests?
| @@ -608,7 +608,7 @@ C_t hlasm_context::get_type_attr(var_sym_ptr var_symbol, const std::vector<size_ | |||
| if (offset.empty()) | |||
| value = setc_sym->get_value(); | |||
| else | |||
| value = setc_sym->get_value(offset.front()); | |||
| value = setc_sym->get_value(offset.front() - 1); | |||
slavek-kucera
approved these changes
Aug 20, 2021
|
Kudos, SonarCloud Quality Gate passed! |
|
🎉 This PR is included in version 0.15.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 0.15.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: lexer generates the ATTR token only on data attributes that always consume the apostrophe
fix: fix format of STNSM and STOSM instructions
fix: CUUTF and CU21 have last parameter optional
fix: evaluation of T'&VAR(num), where VAR is type C-type var symbol array
fix: instruction format of
LLI[LH][LH]feat: limited CNOP instruction implementation