Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to configure logback logger with env variables #8997

Closed
skabashnyuk opened this issue Mar 3, 2018 · 3 comments · Fixed by #8998 or eclipse-che/che-lib#79
Closed

Allow to configure logback logger with env variables #8997

skabashnyuk opened this issue Mar 3, 2018 · 3 comments · Fixed by #8998 or eclipse-che/che-lib#79
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. status/in-progress This issue has been taken by an engineer and is under active development.

Comments

@skabashnyuk
Copy link
Contributor

Description

Now in most cases, we have two regimes of logger INFO or DEBUG.
But during development, especially when Che is working inside of containers,
when it's not easy to reconfigure logback with xml configuration or JMX,
it might be useful to be able to configure particular logger. For example like

CHE_LOGGER_CONFIG=org.eclipse.che=DEBUG,org.eclipse.che.api.installer.server.impl.LocalInstallerRegistry=OFF

To be able to configure ws-master - a user will have to add this variable to che.env
In case of ws-agent - a user will have to add this variable to env configuration of the desired machine.
@skabashnyuk skabashnyuk added status/in-progress This issue has been taken by an engineer and is under active development. kind/task Internal things, technical debt, and to-do tasks to be performed. sprint/current team/platform labels Mar 3, 2018
@skabashnyuk skabashnyuk mentioned this issue Mar 3, 2018
Closed
13 tasks
@benoitf
Copy link
Contributor

benoitf commented Mar 3, 2018

It would be nice to toggle dynamically a logger as well
Through jmx or rest API or with Admin/UD console

@skabashnyuk skabashnyuk changed the title Allow configuring Logback logger with environment variables Allow to configure logback logger with env variables Mar 3, 2018
This was referenced Mar 3, 2018
Merged
Merged
@skabashnyuk
Copy link
Contributor Author

It would be nice to toggle dynamically a logger as well
Through jmx or rest API or with Admin/UD console

Nice idea, do you see a way how it can be easily implemented?

@benoitf
Copy link
Contributor

benoitf commented Mar 3, 2018

I implemented it once, I will search how I had it done

@benoitf benoitf mentioned this issue Mar 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed. status/in-progress This issue has been taken by an engineer and is under active development.
Projects
None yet
Milestone
No milestone
2 participants
@benoitf @skabashnyuk