-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Machine tokens become invalid when workspaces are recovered #7785
Comments
The third solution looks good, but in this case, it is not fully clear what to do with the bootstrapper which takes a machine token from an environment and use it to publish logs. So we need to figure out possible ways, how to put bootstrapper a valid token. |
The goal that we are trying to achieve is to be able to provide a stateless mechanism of interaction between Che master and workspaces, so it means that we need to rework existing codebase related to machine authentication, managing of machine tokens. |
Draft with JWT tokens that are used for authentication between workspace agents and Che master. |
Description
Now machine tokens are stored in memory by workspace server. So after restarting of a workspace server, all machines token become invalid so workspace agent has no ability to request workspace server.
It is needed to investigate how is issue can be solved.
Possible solutions:
MACHINE_TOKEN
env var as something likeINIT_MACHINE_TOKEN
, reworkAgentHttpJsonRequestFactory
to use the token of the current subject instead of initing machine token, generate new machine token after workspace recovering.The third one is preferable.
It is also required to rework a bit generating of machine tokens to make it while token requesting instead of interception of workspace start method.
The text was updated successfully, but these errors were encountered: