Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove exec/terminal agents from dependencies of ws-agent #7482

Closed
garagatyi opened this issue Nov 21, 2017 · 3 comments · Fixed by #8717
Closed

Remove exec/terminal agents from dependencies of ws-agent #7482

garagatyi opened this issue Nov 21, 2017 · 3 comments · Fixed by #8717
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.

Comments

@garagatyi
Copy link

Description

Currently, ws-agent installer has terminal and exec agents as dependencies. But it doesn't depend on it, to be honest.
I suggest removing these dependencies.

Reproduction Steps

OS and version:

Diagnostics:
@garagatyi garagatyi added kind/task Internal things, technical debt, and to-do tasks to be performed. team/platform labels Nov 21, 2017
@garagatyi
Copy link
Author

@gazarenkov FYI

@gazarenkov
Copy link
Contributor

It is logical.
@vparfonov @azatsarynnyy
Does or will and how IDE support the case when there is ws-agent but no exec-agent (no command so) and|or no terminal-agent (terminal wont work)?

@azatsarynnyy
Copy link
Member

IDE in Che 6 should handle it properly.

This was referenced Feb 12, 2018
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove exec/terminal agents from dependencies of ws-agent eclipse-che/che
4 participants
@gazarenkov @skabashnyuk @azatsarynnyy @garagatyi