Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Factory] Replace factory buttons #4501

Closed
slemeur opened this issue Mar 21, 2017 · 3 comments
Closed

[Factory] Replace factory buttons #4501

slemeur opened this issue Mar 21, 2017 · 3 comments
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Milestone

Comments

@slemeur
Copy link
Contributor

slemeur commented Mar 21, 2017

The factory buttons have not been used a lot.
It’s probably good time to remove the service that we have, which was allowing to use logo in the button - and just provide an SVG badge as on dashboard.
We would remove their mention from docs too.

We also need to replace the factory button that we are providing from the dashboard.

@bmicklea bmicklea added the kind/enhancement A feature request - must adhere to the feature request template. label Apr 2, 2017
@slemeur slemeur added this to the 5.7.0 milestone Apr 3, 2017
@skabashnyuk
Copy link
Contributor

@slemeur is that ok for this issue if we marked

    @GET
    @Path("/{id}/image")

and

    @POST
    @Consumes(MULTIPART_FORM_DATA)

as deprecated
Is that the goal of this issue?

@slemeur
Copy link
Contributor Author

slemeur commented Apr 4, 2017

Yes for deprecating.

I will also update the buttons styles (I planned to do that today)

@slemeur
Copy link
Contributor Author

slemeur commented Apr 5, 2017

Close: will be fixed with #2049

@slemeur slemeur closed this as completed Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

No branches or pull requests

3 participants