Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup websocket JSONRPC API endpoint on master #4275

Closed
garagatyi opened this issue Mar 1, 2017 · 0 comments
Closed

Setup websocket JSONRPC API endpoint on master #4275

garagatyi opened this issue Mar 1, 2017 · 0 comments
Assignees
Labels
kind/enhancement A feature request - must adhere to the feature request template. sprint/current
Milestone

Comments

@garagatyi
Copy link

garagatyi commented Mar 1, 2017

We use websocket JSONRPC communication between IDE client and ws-agent.
We consider it as much more modern and handy then the previous websocket communication protocol.
So it was decided to use it in #4099.
Dod for this issue is to setup websocket JSONRPC endpoint on master to allow communication of master as JSONRPC server. It doesn't have to neither handle any new messages nor support messages from old websocket communication protocol.

For resolve this task need to:

  • replace org.eclipse.che.api.workspace.server.event.WorkspaceMessenger, org.eclipse.che.api.machine.server.event.MachineProcessMessenger, org.eclipse.che.api.machine.server.event.MachineStateMessenger with org.eclipse.che.api.core.websocket.impl.BasicWebSocketMessageTransmitter on server side;

  • avoid using org.eclipse.che.ide.websocket.MessageBusImpl

@garagatyi garagatyi added kind/enhancement A feature request - must adhere to the feature request template. status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach team/platform labels Mar 1, 2017
@vparfonov vparfonov added this to the 5.8.0 milestone Apr 11, 2017
@vparfonov vparfonov removed the status/analyzing An issue has been proposed and it is currently being analyzed for effort and implementation approach label Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template. sprint/current
Projects
None yet
Development

No branches or pull requests

3 participants