Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with documentation popup for LSP code completion #3218

Closed
kaloyan-raev opened this issue Nov 30, 2016 · 0 comments · Fixed by #3224
Closed

Issues with documentation popup for LSP code completion #3218

kaloyan-raev opened this issue Nov 30, 2016 · 0 comments · Fixed by #3224
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template.

Comments

@kaloyan-raev
Copy link
Contributor

kaloyan-raev commented Nov 30, 2016

The documentation popup for LSP code completion has some shortcomings:

  • No scrollbars
  • The documentation is displayed in plain text. Although LSP does not enforce any particular format yet (see Proposal: treat CompletionItem#description as markdown microsoft/language-server-protocol#111), popular documentation formats like JavaDoc and PHPDoc contain HTML tags. It would be better to render them instead of displaying them raw, thus making the documentation more readable.
  • Clicking on the popup hides it, thus making impossible to select and copy some text from the documentation.
  • Flickering of the popup while typing

Reproduction Steps:

  1. Build from the latest master.
  2. Start a workspace with the PHP stack and some project sample.
  3. Open the PHP editor.
  4. Invoke code completion and wait for the documentation popup to appear.

Expected behavior:

  • Scrollbars when necessary
  • HTML tags are rendered
  • Possible to select and copy some text from the documentation
  • No flickering while typing

Observed behavior:

image

Che version: latest master
OS and version: Fedora 24
Docker version: 1.10.3
Che install: server (zip)

Additional information:

  • Problem started happening recently, didn't happen in an older version of Che: [No]
  • Problem can be reliably reproduced, doesn't happen randomly: [Yes]
@kaloyan-raev kaloyan-raev self-assigned this Nov 30, 2016
@bmicklea bmicklea added the kind/bug Outline of a bug - must adhere to the bug report template. label Dec 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants