Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have one entrypoint script for ubi and udi #23281

Closed
dkwon17 opened this issue Dec 11, 2024 · 1 comment
Closed

Have one entrypoint script for ubi and udi #23281

dkwon17 opened this issue Dec 11, 2024 · 1 comment
Labels
area/udi Issues and PRs related to the universal developer image https://github.com/devfile/developer-images kind/task Internal things, technical debt, and to-do tasks to be performed. new&noteworthy/che-only Like 'new&noteworthy' but which do not apply to downstream (eg., plugins or devfiles) severity/P2 Has a minor but important impact to the usage or development of the system. team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs.

Comments

@dkwon17
Copy link
Contributor

dkwon17 commented Dec 11, 2024

Is your task related to a problem? Please describe

Currently there is an entrypoint file under base/ubi9 and universal/ubi9.

A second entrypoint file was introduced for universal/ubi when kubedock was introduced as a udi-specific feature in this PR here.

Since the ubi was updated to include kubedock functionalities here, a separate entrypoint file for the ubi and udi is not required

Describe the solution you'd like

Maintain only one entrypoint.sh in base/ubi9, and remove the entrypoint.sh in universal/ubi9

Describe alternatives you've considered

No response

Additional context

No response
@dkwon17 dkwon17 added the kind/task Internal things, technical debt, and to-do tasks to be performed. label Dec 11, 2024
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 11, 2024
@svor svor added severity/P2 Has a minor but important impact to the usage or development of the system. team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs. area/udi Issues and PRs related to the universal developer image https://github.com/devfile/developer-images and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Dec 12, 2024
This was referenced Dec 12, 2024
Closed
Closed
Merged
@dkwon17
Copy link
Contributor Author

dkwon17 commented Dec 18, 2024

Fixed thanks to devfile/developer-images#209

@dkwon17 dkwon17 closed this as completed Dec 18, 2024
@ibuziuk ibuziuk added the new&noteworthy/che-only Like 'new&noteworthy' but which do not apply to downstream (eg., plugins or devfiles) label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/udi Issues and PRs related to the universal developer image https://github.com/devfile/developer-images kind/task Internal things, technical debt, and to-do tasks to be performed. new&noteworthy/che-only Like 'new&noteworthy' but which do not apply to downstream (eg., plugins or devfiles) severity/P2 Has a minor but important impact to the usage or development of the system. team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs.
Projects
Eclipse Che Team B Backlog
Status: ✅ Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@svor @ibuziuk @che-bot @dkwon17