Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor is not started when workspace started from some devfiles from the registry.devfile.io #22525

Closed
tolusha opened this issue Sep 18, 2023 · 9 comments
Assignees
Labels
area/editors kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs.

Comments

@tolusha
Copy link
Contributor

tolusha commented Sep 18, 2023

Describe the bug

Editor is not started when workspace started from some devfiles from the registry.devfile.io:

  • django
  • go
  • python
  • java-vertex
  • wildfly

Che version

next (development version)

Steps to reproduce

  1. Deploy Eclipse Che on OpenShift
  2. Configure external devfile registry https://registry.devfile.io
oc patch checluster/eclipse-che --patch '{"spec": {"components": {"devfileRegistry": {"disableInternalRegistry": true, "externalDevfileRegistries": [{"url": "'https://registry.devfile.io'"}]}}}}' --type=merge -n eclipse-che
  1. Try a start a workspace from the stacks above

screenshot-eclipse-che apps ci-ln-zpry0jk-76ef8 aws-2 ci openshift org-2023 09 18-14_28_44

Expected behavior

Workspace is started successfully

Runtime

OpenShift

Screenshots

No response

Installation method

OperatorHub

Environment

Linux

Eclipse Che Logs

No response

Additional context

No response

@tolusha tolusha added kind/bug Outline of a bug - must adhere to the bug report template. area/editors team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs. labels Sep 18, 2023
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 18, 2023
@l0rd l0rd added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 19, 2023
@l0rd
Copy link
Contributor

l0rd commented Sep 19, 2023

Included in #20251

@l0rd
Copy link
Contributor

l0rd commented Oct 12, 2023

Depends on #21778

@RomanNikitenko
Copy link
Member

The pull request for the Vert.x Java Stack: devfile/registry#295

@RomanNikitenko
Copy link
Member

The pull request for the WildFly Bootable Jar Stack: devfile/registry#296

@ibuziuk
Copy link
Member

ibuziuk commented Feb 15, 2024

@RomanNikitenko both PRs have been merged and #22814 is closed
can we close this issue as well cc: @musienko-maxim

@RomanNikitenko
Copy link
Member

@ibuziuk
There are 5 stacks in the PR description, I tested creation of workspace for those stacks on the dogfooding instance.
A workspace starts successfully for django, go, python, it still fails for java-vertex and wildfly.

I see that new versions (with fixed devfile) for the stacks are still absent on the devfile.io:

image

Do you know when it's going to be updated?
At the same it's OK for me to close the current issue as the PRs were merged and we are just waiting for update on the devfile.io side.

@RomanNikitenko RomanNikitenko moved this from 📅 Planned for this Sprint to Ready for Review in Eclipse Che Team B Backlog Feb 16, 2024
@ibuziuk
Copy link
Member

ibuziuk commented Feb 20, 2024

@RomanNikitenko is it still outdated or the issue can be resolved

@RomanNikitenko
Copy link
Member

At the moment the registry doesn't contain my changes, but I guess it should be updated tomorrow:
https://github.com/devfile/registry?tab=readme-ov-file#registry

The public registry is updated weekly, by 12pm EST Wednesdays, with any updated stacks in this repository.

@RomanNikitenko
Copy link
Member

The devfile registry was updated,
I successfully started workspaces for WildFly Bootable Jar and Vert.x Java stacks

image image

@github-project-automation github-project-automation bot moved this from Ready for Review to ✅ Done in Eclipse Che Team B Backlog Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/editors kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. team/B This team is responsible for the Web Terminal, the DevWorkspace Operator and the IDEs.
Projects
None yet
Development

No branches or pull requests

5 participants