Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When specifying remotes as URL parameter, implicit remote names should be the user/organization name #21943

Closed
Tracked by #21941
dkwon17 opened this issue Jan 19, 2023 · 1 comment
Labels
area/dashboard area/factory/dashboard Issues related to factories frontend (che user dashboard side) kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system. sprint/next

Comments

@dkwon17
Copy link
Contributor

dkwon17 commented Jan 19, 2023

Is your enhancement related to a problem? Please describe

This enhancement comes from a discussion here: eclipse-che/che-docs#2531 (comment)

When remotes are provided to the factory url in this format:

{CHE_HOST}/#{GIT_URL}?remotes={https://github.com/dkwon17/che,https://github.com/eclipse/che,https://github.com/user1/che,https://github.com/user2/che}

The implicit names for the remotes are as follows:

origin -> https://github.com/dkwon17/che
upstream -> https://github.com/eclipse/che
fork1 -> https://github.com/user1/che
fork2 -> https://github.com/user2/che

Describe the solution you'd like

Instead of having the last two implicit names be fork1 and fork2 it would be great if their names were the user or organization name instead.

In this case, they would be:

user1 -> https://github.com/user1/che
user2 -> https://github.com/user2/che

Alternatively, having all of the implicit names be organization names could be useful too:

dkwon17 -> https://github.com/dkwon17/che
eclipse -> https://github.com/eclipse/che
user1 -> https://github.com/user1/che
user2 -> https://github.com/user2/che

Describe alternatives you've considered

Additional context

No response

@dkwon17 dkwon17 added the kind/enhancement A feature request - must adhere to the feature request template. label Jan 19, 2023
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 19, 2023
@dkwon17 dkwon17 added severity/P2 Has a minor but important impact to the usage or development of the system. area/dashboard area/factory/dashboard Issues related to factories frontend (che user dashboard side) labels Jan 19, 2023
@amisevsk amisevsk removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 20, 2023
@ibuziuk ibuziuk mentioned this issue Feb 15, 2023
56 tasks
@ibuziuk ibuziuk mentioned this issue Mar 21, 2023
50 tasks
@che-bot
Copy link
Contributor

che-bot commented Sep 3, 2023

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 3, 2023
@che-bot che-bot closed this as completed Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard area/factory/dashboard Issues related to factories frontend (che user dashboard side) kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system. sprint/next
Projects
None yet
Development

No branches or pull requests

4 participants