Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Traefik to 2.9.6 version #21869

Closed
framar89 opened this issue Dec 7, 2022 · 4 comments
Closed

Update Traefik to 2.9.6 version #21869

framar89 opened this issue Dec 7, 2022 · 4 comments
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed.
Milestone

Comments

@framar89
Copy link

framar89 commented Dec 7, 2022

Summary

Currently the default image version used for traefik is quay.io/eclipse/che--traefik:v2.8.1-4e52a5e2495484f5e19a49edfd2f652b0bce7b3603fa0df545ed90168ffae1c3 which has a critical vulnerability as showed in https://quay.io/repository/eclipse/che--traefik?tab=tags
I ran a security scan using Trivy (https://trivy.dev/results/?image=traefik:v2.8.2) for the Dockerhub image traefik:v2.8.2 and it tells that there are no vulnerabilities.

So my questions are:

  • Can traefik be updated to at least 2.8.2? It's a build update, so I don't expect any breaking changes.
  • I saw that the image can be customized in Eclipse Che CRD so that I can temporarily use the one provided by Dockerhub (traefik:v2.8.2). Is it compatible? Do I need to change anything else?
  • Are there any differences from the images in https://quay.io/repository/eclipse/che--traefik and the corresponding traefik in Dockerhub?

Thanks

Relevant information

No response

@framar89 framar89 added the kind/question Questions that haven't been identified as being feature requests or bugs. label Dec 7, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 7, 2022
@tolusha
Copy link
Contributor

tolusha commented Dec 7, 2022

@framar89

  1. Yes, it can be updated.
  2. You can try traefik:v2.8.2 image without any changes and it must be compatible. If it works for you, I will create a PR.
    Use the following command to set a new image in CheCluster CR
kubectl patch checluster/eclipse-che --patch '{"spec": {"networking": {"auth": {"gateway": {"deployment": {"containers": [{"name": "gateway", "image": "traefik:v2.8.2"}]}}}}}}' --type=merge -n eclipse-che
  1. There can't be any differences, quay.io contains a copy of docker.io image.

@framar89
Copy link
Author

framar89 commented Dec 7, 2022

Unfortunately traefik:v2.8.2 does not work but I tried traefik:v2.9.5 (released 20 days ago) and it worked.

So, I think you can update to v2.9.5.

@tolusha
Copy link
Contributor

tolusha commented Dec 8, 2022

traefik:v2.8.2 does not work for me either.
The latest greatest traefik:v2.9.6 works fine for me. I will open a PR to switch to the new image.

@tolusha tolusha changed the title Update Traefik to 2.8.2 (or newer version) Update Traefik to 2.9.6 version Dec 8, 2022
@tolusha tolusha added area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed. and removed kind/question Questions that haven't been identified as being feature requests or bugs. status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Dec 8, 2022
@tolusha tolusha mentioned this issue Dec 8, 2022
82 tasks
@nickboldt
Copy link
Contributor

nickboldt commented Dec 8, 2022

nickboldt added a commit to eclipse-che/che-release that referenced this issue Dec 8, 2022
Change-Id: I99d78981aedd73146716438009543027fceda008
Signed-off-by: Nick Boldt <[email protected]>
@tolusha tolusha closed this as completed Jan 10, 2023
@tolusha tolusha added this to the 7.60 milestone Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/che-operator Issues and PRs related to Eclipse Che Kubernetes Operator kind/task Internal things, technical debt, and to-do tasks to be performed.
Projects
None yet
Development

No branches or pull requests

4 participants