Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devfile-registry] Rework the devworkspace generation process #21831

Closed
svor opened this issue Nov 22, 2022 · 1 comment
Closed

[devfile-registry] Rework the devworkspace generation process #21831

svor opened this issue Nov 22, 2022 · 1 comment
Labels
area/devfile-registry area/samples kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.

Comments

@svor
Copy link
Contributor

svor commented Nov 22, 2022

Is your task related to a problem? Please describe

For now we are using libraries to generate DevWorkspaces with Theia and VS Code editor, once devfile/devworkspace-operator#939 was merged, DevWorkspaces support a new field .spec.contributions.

When generating devworkspaces during the build of the devfile registry, editors/other components should be injected into contributions field:

 apiVersion: workspace.devfile.io/v1alpha2
 kind: DevWorkspace
 metadata:
   name: golang-example
   namespace: <username>-che
 spec:
   routingClass: che
   started: false
   contributions:
+    - name: theia
+      kubernetes:
+        name: che-code-workspace1cfc13df8bcf497a
+        namespace: <username>-che
   template:
     components:
       - name: tools
         container:
           image: udi8
           # etc
-      - name: theia
-        plugin:
-          kubernetes:
-            name: che-code-workspace1cfc13df8bcf497a
-            namespace: <username>-che
@svor svor added kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. area/devfile-registry area/samples labels Nov 22, 2022
@svor
Copy link
Contributor Author

svor commented Dec 7, 2022

duplicate of #21832

@svor svor closed this as completed Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-registry area/samples kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

No branches or pull requests

1 participant