Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide FAQ / Known issues / Troubleshooting for devfile v1 -> devfile v2 convertion #21005

Closed
Tracked by #21200 ...
ibuziuk opened this issue Jan 12, 2022 · 18 comments
Closed
Tracked by #21200 ...
Assignees
Labels
area/devfile-spec Issues related to Devfile v2 area/doc Issues related to documentation kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.

Comments

@ibuziuk
Copy link
Member

ibuziuk commented Jan 12, 2022

Is your task related to a problem? Please describe

With the switch to the DevWorkspace engine, devfile v2 becomes a default format for workspace definition. Need to provide clear documentation for conversion of devfile v1 devfile v2 and publish it on the https://www.eclipse.org/che/docs
Probably it also makes sense to publish a blog post at https://che.eclipseprojects.io/

Describe the solution you'd like

Clear documentation for devfile v1 -> devfile v2 convertion

Describe alternatives you've considered

There is already migration documentation that is part of the https://devfile.io/docs/devfile/2.1.0/user-guide/migrating-to-devfile-v2.html

As an alternative, we can just fall back on to the official devfile docs. Which would probably be the best approach

Additional context

Related to #20845

@ibuziuk ibuziuk added kind/task Internal things, technical debt, and to-do tasks to be performed. area/devfile/v1 area/doc Issues related to documentation area/devfile-spec Issues related to Devfile v2 labels Jan 12, 2022
@ibuziuk ibuziuk changed the title Provide documentation for manual devfile v1 -> devfile v2 convertion Provide documentation for devfile v1 -> devfile v2 convertion Jan 12, 2022
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 12, 2022
@ibuziuk ibuziuk added severity/P1 Has a major impact to usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jan 12, 2022
@benoitf benoitf added severity/P2 Has a minor but important impact to the usage or development of the system. and removed severity/P1 Has a major impact to usage or development of the system. labels Jan 12, 2022
@ibuziuk
Copy link
Member Author

ibuziuk commented Jan 12, 2022

cc: @themr0c is che-docs team initial creator and supporter of https://devfile.io/docs/devfile/2.1.0/user-guide/migrating-to-devfile-v2.html ?

@benoitf
Copy link
Contributor

benoitf commented Jan 12, 2022

@l0rd seems to be the creator https://github.com/devfile/docs/commits/8a4ae3ceda1695fa8caced9c65ad10971bffab2f/docs/modules/ROOT/pages/migration_guide.adoc

@themr0c
Copy link
Contributor

themr0c commented Jan 13, 2022

@ibuziuk In the devfile documentation project, I only helped to set up things and migrate initial content from che-docs. The project is in the hands of other people from the DevTools Docs team: @rkratky as Content Strategist, and @jc-berger as main writer.

@rkratky
Copy link

rkratky commented Jan 13, 2022

@ibuziuk, I'd suggest falling back on the devfile docs whenever possible. If the existing migration docs need modifying, please open an issue in that repo - we'll pick it up.

@themr0c
Copy link
Contributor

themr0c commented Jan 13, 2022

The existence of the devfile-converter library [1] is probably worth mentioning in devfile docs [2].
[1] https://www.npmjs.com/package/@eclipse-che/devfile-converter
[2] https://devfile.io/docs/devfile/2.1.0/user-guide/migrating-to-devfile-v2.html

-> devfile/api#722

@ibuziuk
Copy link
Member Author

ibuziuk commented Jan 13, 2022

@themr0c I doubt that customers will be using an internal lib for conversion.

I agree that we need to fall back on https://devfile.io/docs/devfile/2.1.0/user-guide/migrating-to-devfile-v2.html though.
Basically, someone needs to meticulously review the docs and contribute if there are some missing bits.
@benoitf maybe you can give a hand with this since you know all the details and edge cases that are covered as part of the https://github.com/che-incubator/devfile-converter ?

@themr0c
Copy link
Contributor

themr0c commented Jan 13, 2022

What would make sense in che-docs is a procedure "Using the Dashboard to convert a devfile" explaining only the Che specific stuff, with the Additional resources section pointing to https://devfile.io/docs/devfile/2.1.0/user-guide/migrating-to-devfile-v2.html. Maybe also "Using the Che-Theia IDE to convert a devfile"?

@themr0c
Copy link
Contributor

themr0c commented Jan 13, 2022

Basically, someone needs to meticulously review the docs and contribute if there are some missing bits.

Fully agree!

@ibuziuk
Copy link
Member Author

ibuziuk commented Feb 21, 2022

The current plan discussed on the Cabal call is to provide FAQ / Known issues to https://devfile.io/docs/devfile/2.1.0/user-guide/migrating-to-devfile-v2.html

@ibuziuk ibuziuk mentioned this issue Feb 22, 2022
24 tasks
@ibuziuk
Copy link
Member Author

ibuziuk commented Feb 22, 2022

@rkratky
Copy link

rkratky commented Feb 23, 2022

@ibuziuk, that's a bug (since yesterday's republication), and we're working on fixing it.

@rkratky
Copy link

rkratky commented Feb 23, 2022

@ibuziuk, the bug is fixed: https://devfile.io/docs/devfile/2.1.0/user-guide/migrating-to-devfile-v2/

(Note that URL does not have '.html' at the end.)

@ibuziuk ibuziuk mentioned this issue Mar 14, 2022
35 tasks
@ibuziuk
Copy link
Member Author

ibuziuk commented Mar 17, 2022

@ibuziuk ibuziuk mentioned this issue Apr 5, 2022
45 tasks
@ibuziuk ibuziuk changed the title Provide documentation for devfile v1 -> devfile v2 convertion Provide FAQ / Known issues / Troubleshooting for devfile v1 -> devfile v2 convertion Apr 6, 2022
@ibuziuk ibuziuk self-assigned this Apr 6, 2022
@benoitf
Copy link
Contributor

benoitf commented Apr 14, 2022

Here are some points to add about Troubleshooting for devfile v1 --> devfile v2

  1. Main point is that Che-Theia editor will inject by default all their plug-ins into a 'user-defined' container.
    If the devfile v1 contains at least one container component then it's in pretty good shape to work.
    if there is no component with one container it'll fail.

This limitation should be fixed when devfile/devworkspace-operator#656 will be implemented. Because the editor definition will contain a default component to add in the devfile.

  1. Needs to check that the 'user container' is a valid container for starting Theia endpoint inside (it'll change the entrypoint of the container). Once Extend the DevWorkspaceTemplate spec with containers contributions devfile/devworkspace-operator#656 is implemented, it'll use the post-start container event to run the editor endpoint.

@benoitf
Copy link
Contributor

benoitf commented Apr 14, 2022

if the startup fails, it may be good to try to use a universal developer image as the only component

it should allow to boot the workspace properly

components:
  - name: tools
    container:
      image: quay.io/devfile/universal-developer-image:ubi8-latest
      memoryLimit: 3Gi

@benoitf
Copy link
Contributor

benoitf commented Apr 14, 2022

and also if the current user container is not working with plug-ins being executed there

It's possible for che-theia to apply an attribute
che-theia.eclipse.org/sidecar-policy

default value is 'use dev container' but to use 'sidecar container as before mergeImage as value of the attribute should be set.

https://github.com/eclipse-che/che-theia/blob/main/tools/devworkspace-handler/src/devfile/che-theia-plugins-devfile-resolver.ts#L113-L119

@benoitf
Copy link
Contributor

benoitf commented Apr 15, 2022

I've also created an issue that may help:

@ibuziuk ibuziuk added the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Apr 28, 2022
@ibuziuk
Copy link
Member Author

ibuziuk commented Apr 28, 2022

PR with troubleshooting guide is ready for review - devfile/docs#153

@ibuziuk ibuziuk closed this as completed May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/devfile-spec Issues related to Devfile v2 area/doc Issues related to documentation kind/task Internal things, technical debt, and to-do tasks to be performed. severity/P2 Has a minor but important impact to the usage or development of the system. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Development

No branches or pull requests

5 participants