Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redux store with default plugins from CR without refreshing dashboard #20960

Closed
dkwon17 opened this issue Dec 21, 2021 · 1 comment
Closed
Labels
area/dashboard kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system. sprint/next

Comments

@dkwon17
Copy link
Contributor

dkwon17 commented Dec 21, 2021

Is your enhancement related to a problem? Please describe

From eclipse-che/che-dashboard#426, the default DevWorkspace plugins in the Redux store are only set on the preload phase (here). As a result, changes to the default plugins list (ie. server.workspacesDefaultPugins in the Che CR) are only updated in the Redux store when refreshing (F5) the Che dashboard.

It would be great if the default plugins are updated in the Redux store when they are changed in the Che CR without having to refresh the dashboard.

Describe the solution you'd like

Use an approach similar to watching changes: https://github.com/eclipse-che/che-dashboard/blob/main/packages/dashboard-frontend/src/services/bootstrap/PreloadData.ts#L115

Add a function similar to watchInNamespace from workspace-api.ts, to serverConfigApi.ts to watch for changes to server.workspacesDefaultPugins in the Che CR.

Additional context

Related issue: #20090
Related PR: eclipse-che/che-dashboard#426

@dkwon17 dkwon17 added kind/enhancement A feature request - must adhere to the feature request template. area/dashboard labels Dec 21, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Dec 21, 2021
@dkwon17 dkwon17 added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Dec 21, 2021
@che-bot
Copy link
Contributor

che-bot commented Jun 20, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 20, 2022
@che-bot che-bot closed this as completed Jun 27, 2022
@dkwon17 dkwon17 reopened this Jun 27, 2022
@che-bot che-bot closed this as completed Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dashboard kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system. sprint/next
Projects
None yet
Development

No branches or pull requests

3 participants