Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Mattermost notifications for che release stages #18906

Closed
nickboldt opened this issue Jan 27, 2021 · 4 comments
Closed

Enable Mattermost notifications for che release stages #18906

nickboldt opened this issue Jan 27, 2021 · 4 comments
Assignees
Labels
area/ci CI build and releases, PR testing, & whitelabel/productization issues kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone

Comments

@nickboldt
Copy link
Contributor

nickboldt commented Jan 27, 2021

Is your enhancement related to a problem? Please describe.

Communication of release status is sketchy and manual. We could automate it so that it's more obvious what's happening.

Describe the solution you'd like

For every successful completion of a PHASE of the che-release process, send a mattermost notification w/ link to relevant status content:

eg.,

che-machine-exec 7.26.0 released :: https://quay.io/eclipse/che-machine-exec:7.26.0
This release: https://github.com/eclipse/che-machine-exec/actions?query=workflow%3A%22Release%22
Overall release: https://github.com/eclipse/che-release/actions?query=workflow%3A%22Release%22

GH action built-in: https://github.com/marketplace/actions/mattermost
MM channel to notify: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-releases

Channel would therefore get about 10 announcements, once a week, for each release.

@nickboldt nickboldt added the kind/enhancement A feature request - must adhere to the feature request template. label Jan 27, 2021
@nickboldt nickboldt added area/ci CI build and releases, PR testing, & whitelabel/productization issues area/productization labels Jan 27, 2021
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 27, 2021
@nickboldt nickboldt added severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Jan 27, 2021
@nickboldt nickboldt added this to the 7.27 milestone Jan 27, 2021
@nickboldt nickboldt changed the title Enable mattermost notifications for che release stages Enable Mattermost notifications for che release stages Jan 27, 2021
@nickboldt
Copy link
Contributor Author

Initial prototype for announcing the overall release is done:

With this, we can:

  • announce when the whole release is done (manual workflow trigger, to remind people about issue triage) : DONE

In future, we could:

  • announce individual stages in the release are done (API call when stuff is done in other repos)
  • announce when everything is done (except the PRs that need merging) (when operator and chectl are merged)

@nickboldt
Copy link
Contributor Author

nickboldt commented Mar 5, 2021

For example... eclipse-che/che-machine-exec#134 (requires uploading the MATTERMOST_WEBHOOK_URL secret to work)

@nickboldt
Copy link
Contributor Author

nickboldt commented Mar 11, 2021

che-theia notification failed because:

2021-03-11T12:07:03.2004173Z ##[command]/usr/bin/docker build -t 5588e4:973db1779c234cc89fcd708ca4c62af8 -f "/home/runner/work/_actions/mattermost/action-mattermost-notify/master/Dockerfile" "/home/runner/work/_actions/mattermost/action-mattermost-notify/master"
...
2021-03-11T12:08:39.5760632Z Successfully tagged 5588e4:973db1779c234cc89fcd708ca4c62af8

but then

docker image prune -a -f
...
2021-03-11T12:09:25.1531776Z untagged: 5588e4:973db1779c234cc89fcd708ca4c62af8

-- https://pipelines.actions.githubusercontent.com/r9pXOaZgznilET3xqjzkK4PuFIyiUj24cGg6t9ne59Rxdg3CN0/_apis/pipelines/1/runs/3327/signedlogcontent/3?urlExpires=2021-03-11T14%3A57%3A47.8776142Z&urlSigningMethod=HMACV1&urlSignature=XYWivSWtridUwtQgO9vGl%2Fq0F3AZ1MhHk4ZJGP6AwDQ%3D

So the container created at the start of the run is untagged before it can be used at the end.

Workaround:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI build and releases, PR testing, & whitelabel/productization issues kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

3 participants