Use the che-docs container for github workflow actions in che-docs

[themr0c]

In order to have every process in che-docs use exactly the same version of the tools, use the quay.io/eclipse/che-docs container in GitHub workflow actions for all processes that have tools built in the che-docs containers:

• Execute antora
• Execute vale
• Execute linkchecker
• Execute bash scripts

[nickboldt]

Current release action:

https://github.com/eclipse/che-docs/blob/master/.github/workflows/release.yml

which just runs:

https://github.com/eclipse/che-docs/blob/master/make-release.sh

to perform tagging/branching/updating the VERSION file (which will be changed to the playbook file in #18864).

So...

are you saying we should update a different workflow action?

• https://github.com/eclipse/che-docs/blob/master/.github/workflows/build-pr-docs.yaml#L22
• https://github.com/eclipse/che-docs/blob/master/.github/workflows/link-checker.yaml#L23
• https://github.com/eclipse/che-docs/blob/master/.github/workflows/publish-netlify.yaml#L53-L65 ?

[themr0c]

Yes that's not for the release script but for the other ones!

[nickboldt]

So instead of

           yarn
           ./node_modules/.bin/antora generate antora-playbook.yml

what are you suggesting should be done instead? How do you want quay.io/eclipse/che-docs used?

[themr0c]

What we do in devfile and Jenkinsfile: run antora / linkchecker / vale directly in the quay.io/eclipse/che-docs container.
For vale it's also quite important to keep same version because of some surprises with upgrades.

[yhontyk]

Issue in docs Jira https://issues.redhat.com/browse/RHDEVDOCS-2537

[themr0c]

Example of surprise: linkchecker running fine using the che-docs image, broken using the official and outdated linkchecker image: eclipse-che/che-docs#1801

[themr0c]

Example:

In the middle, linkchecker executed using che-docs container.
On the right, linkchecker executed using linkchecker/lickchecker container.

Options are not taken into account, a big subset of the URLs is not checked:

[benoitf]

@themr0c should we close this issue as you've done by yourself some enhancements ?

[themr0c]

You helped a lot. I just checked, seems we are good yes.