Provide plug-ins recommendations #18274

benoitf · 2020-11-03T13:57:29Z

Is your enhancement related to a problem? Please describe.

When user starts with a repository without devfile, they don't have any plug-ins enabled.
For example using spring petclinic, no java intellisense is provided.

use cases are the following:

Provide featured plug-ins on fresh repositories without devfiles (no plug-ins) based on what are the featured plug-ins in plug-in registry.
Suggest/Recommend plug-ins when opening files based on what is stored in che plugin-registry
Suggest/Recommend plug-ins when opening projects that have .vscode/extensions.json file (and matching plug-ins available from the plug-in registry)
Suggest/Recommend plug-ins when opening .code-workspace files that have extensions/recommandations field (and matching plug-ins available from the plug-in registry)

Describe the solution you'd like

Featured plug-ins are 'manually selected' plug-ins that are promoted from the plug-in registry.
All other recommendations are automatically generated from plug-in registry content.

Acceptance Criteria

If the user accepts the recommendations the workspace should be reloaded.
If the workspace already includes the recommended extensions the user won't be prompted.
If the user ignores the recommended extensions he shouldn't be asked again when the workspace is restarted.
When accepting recommendations user should be prompted if files .vscode/extensions.json should not .che/che-theia-plugins.yaml be created/edited or not.
If the user updates .vscode/extensions.json or .che/che-theia-plugins.yaml he should be asked if he wants to include the extensions and reload the workspace.

The text was updated successfully, but these errors were encountered:

gattytto · 2020-11-03T16:22:26Z

Provide featured plug-ins on fresh repositories without devfiles (no plug-ins) based on what are the featured plug-ins in plug-in registry.

Suggest/Recommend plug-ins when opening files based on what is stored in che plugin-registry

it would be nice to have a "notes" field in plugins meta.yaml, so one can add extra notes for different versions of the same plugin/extensions-combination. example: "you are using the haskell debug-adapter, but it will not be activated until you open a .hs (or others haskell) file". Or "haskell stack/bazel build is required for peeking/going to a definition in code files, click to run or it will when you open a haskell code file".
So the user can be warned of inactive extensions and how to activate them, or how to feed artifact caches before opening code files.

for the extension-based recommendations there's this field in package.json for vsix extensions:

"contributes": {
    "languages": [
      {
        "id": "haskell",
        "aliases": [
          "Haskell",
          "haskell"
        ],
        "extensions": [
          ".hs"
        ]
      }

benoitf · 2020-11-03T17:24:43Z

hello @gattytto, yes this fragment of vsix package.json will be used to make generic recommendations
But I'm unsure to get the idea about the notes field of more precisely the use-case you're describing on a plug-in there but not activated.
Could you add more details and how VS Code is behaving on this specific use-case ?
Most of stuff is performed by doing lazy loading: we activate extensions only if user triggers a specific command or if a file is in present in a workspace.
I'm afraid that we may end in tons of 'notes' if I open a workspace like:
you can open java files, you can open yaml files, you have the debugger, etc
I suppose viewing plug-ins list could be enriched or we need a dedicated UI, because too many notes will flood the user ?

ericwill · 2020-11-03T17:27:47Z

@gattytto I think what you're describing might be better suited for the README of the sample project, that way it can be formatted in a clear way and users can always reference it.

l0rd · 2021-02-10T12:05:56Z

I have added some "Acceptance Criteria" that I had initially included in #18668

nickboldt · 2021-02-23T13:10:08Z

Target 7.27, but can backport to 7.26.2 if @sympatheticmoose deems it important enough.

sympatheticmoose · 2021-02-23T15:05:30Z

We'd hoped for this in CRW 2.7 (7.26)

benoitf · 2021-02-23T15:08:38Z

review is taking too long. it's like in infinite loop

sympatheticmoose · 2021-02-23T15:16:56Z

@benoitf anything that would help resolve? Maybe a dedicated call/working session?

tsmaeder · 2021-02-23T15:38:54Z

@benoitf @sympatheticmoose I checked back last Thursday and some changes had not been pushed. Friday was H&H day. Also: not all comments were addressed and a companion docs PR is missing. If that requirement should be waived, let's discuss it.
Currently I'm just waiting for the docs PR and an answer to all questions.
Also, a little ping in the plugins/editors chat helps attract the attention if you urgently need feedback.

benoitf · 2021-02-23T16:09:35Z

@tsmaeder PR is there for months, no review for a couple of weeks after changes have been made, and 'changes not pushed was fixed in 10mn' so problem is elsewhere.
And AFAIK it's a review by a whole team not by you explicitly.
And it looks like you're doing egg and chicken problem with doc if we reduce the scope at the end.

tsmaeder · 2021-02-23T16:24:10Z

@benoitf the problem with the PR sitting there is that me personally, I get added as a reviewer "as a code owner" to way more than I could ever review. So I just look at the ones where I kinda know I can meaningfully contribute or where I'm explicitly requested. Reviewing a PR of this size takes at least a couple of hours if you take it seriously, so it's not a side task.
I wasn't aware of this PR until a couple of weeks ago. Since this work is not going through our planning cycle, it's not on our radar until someone puts it there. If your PR just sits gathering dust, maybe ping someone on a different channel?

tsmaeder · 2021-02-23T16:27:24Z

About the docs PR: I think we need one because of the new preference setting. I wasn't sure about where the key was used: maybe it was documented elsewhere. Seems it's not.

ericwill · 2021-02-23T16:27:44Z

There are unaddressed comments from @sunix from 28 days ago:

feat(recommendations): Provide a plug-in for recommendations che-theia#916 (comment)
feat(recommendations): Provide a plug-in for recommendations che-theia#916 (comment)
feat(recommendations): Provide a plug-in for recommendations che-theia#916 (comment)

If they aren't blocking concerns then let's discuss or comment in the PR. As for this comment, @sunix please check it again.

benoitf · 2021-02-23T16:36:29Z

@ericwill I tried to fix the requested changes comment first because if you don't fix the blocking stuff, other comments won't change something

it has been fixed there: eclipse-che/che-theia#916 (review) and no reply since.

so when blocking changes are gone, I may address other comments

nickboldt · 2021-02-23T17:06:32Z

We'd hoped for this in CRW 2.7 (7.26)

@sympatheticmoose might help to escalate this from "P2" priority to something higher so it floats higher on the auto-backlog. Also setting it to the 7.26 milestone would be a good indicator that this is meant for CRW 2.7

This issue also has no assignee, and is not labelled with a team owner, only the dev-experience area.

ericwill · 2021-02-23T17:06:41Z

We'd hoped for this in CRW 2.7 (7.26)

In the future, let's discuss these during prioritization and create downstream tickets with appropriate fixVersions. This issue has a milestone of 7.27 and is marked as P2. Apart from a small entry in the 2.7 JIRA epic description, I have no way of knowing that this is a priority item for CRW 2.7.

@ericwill I tried to fix the requested changes comment first because if you don't fix the blocking stuff, other comments won't change something

it has been fixed there: eclipse/che-theia#916 (review) and no reply since.

so when blocking changes are gone, I may address other comments

I can see your point, but leaving comments unaddressed for weeks also gives the impression that the PR isn't being worked on or is low priority. In the future, let's:

address comments on the PR
communicate CRW priorities better

and I will make sure reviews are quicker.

nickboldt · 2021-02-23T17:15:03Z

Maybe it's time to implement an "epic/crw26" label so we can more easily query for issues that PM wants from upstream, and then be able to turn those into JIRAs linked to the CRW epic issue?

Right now there's no way to know if a given Che issue is important for a given CRW release, or to easily query for more than one label.

Because we also can't have more than one milestone per issue (unlike JIRA, which can have multiple affectsVersion and fixVersion values), and we don't currently use a "backport" label, only a backport PR will bear the information that a given issue's solution in 7.27 was also backported to 7.26.x.

So... WDYT about adding these labels and encouraging their consistent use in future?

backport-requested
backported
and
epic/crw26
epic/crw27
...

nickboldt · 2021-02-25T14:09:55Z

Sounds like it's too late to get this backported into 7.26.x and CRW 2.7. I've updated the 2.7 & 2.8 epics accordingly.

Ohrimenko1988 · 2021-04-21T13:27:27Z

I don't observe such functionality on the latest Che
chectl version: chectl/0.0.20210420-next.13d2bcd linux-x64 node-v12.22.1
devfile:

apiVersion: 1.0.0
metadata:
  name: java-maven-vk57v
projects:
  - name: console-java-simple
    source:
      location: 'https://devfile-registry-iokhrime-che.192.168.99.254.nip.io/resources/java-maven-console-java-simple-java1.11.zip'
      type: zip

I created a workspace using mentioned devfile. As you can see it contains only the project definition without any plugins.
After the workspace start I opened it, expanded project and opened the java file. But no prompts were been shown.

benoitf · 2021-04-22T05:53:13Z

@Ohrimenko1988 this issue has already been done
I've reopened #19610

benoitf added the kind/enhancement A feature request - must adhere to the feature request template. label Nov 3, 2020

che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Nov 3, 2020

azatsarynnyy added area/dev-experience severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Nov 3, 2020

azatsarynnyy changed the title ~~Provide plug-ins recommandations~~ Provide plug-ins recommendations Nov 3, 2020

benoitf mentioned this issue Dec 21, 2020

feat(featured): Add featured list of CheTheia plug-ins to enable by default eclipse-che/che-plugin-registry#778

Merged

9 tasks

sunix mentioned this issue Jan 22, 2021

feat(recommendations): Provide a plug-in for recommendations eclipse-che/che-theia#916

Merged

9 tasks

azatsarynnyy mentioned this issue Feb 3, 2021

Expand support of devfile v2 in Che to include definition of Editors and Theia Plugins #18668

Closed

7 tasks

l0rd mentioned this issue Feb 10, 2021

Remove plugins from the Devfile schema #18669

Closed

nickboldt added this to the 7.27 milestone Feb 23, 2021

benoitf mentioned this issue Mar 2, 2021

feat(recommendations-plugin): Add the documentation for the recommendations plug-in eclipse-che/che-docs#1876

Merged

6 tasks

benoitf self-assigned this Mar 2, 2021

benoitf closed this as completed Mar 3, 2021

sympatheticmoose added the new&noteworthy For new and/or noteworthy issues that deserve a blog post, new docs, or emphasis in release notes label Mar 26, 2021

Ohrimenko1988 reopened this Apr 21, 2021

benoitf closed this as completed Apr 22, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Provide plug-ins recommendations #18274

Provide plug-ins recommendations #18274

benoitf commented Nov 3, 2020 •

edited by l0rd

Loading

gattytto commented Nov 3, 2020 •

edited

Loading

benoitf commented Nov 3, 2020

ericwill commented Nov 3, 2020

l0rd commented Feb 10, 2021

nickboldt commented Feb 23, 2021

sympatheticmoose commented Feb 23, 2021

benoitf commented Feb 23, 2021

sympatheticmoose commented Feb 23, 2021

tsmaeder commented Feb 23, 2021

benoitf commented Feb 23, 2021

tsmaeder commented Feb 23, 2021

tsmaeder commented Feb 23, 2021

ericwill commented Feb 23, 2021 •

edited

Loading

benoitf commented Feb 23, 2021

nickboldt commented Feb 23, 2021 •

edited

Loading

ericwill commented Feb 23, 2021

nickboldt commented Feb 23, 2021

nickboldt commented Feb 25, 2021

Ohrimenko1988 commented Apr 21, 2021

benoitf commented Apr 22, 2021 •

edited

Loading

Provide plug-ins recommendations #18274

Provide plug-ins recommendations #18274

Comments

benoitf commented Nov 3, 2020 • edited by l0rd Loading

Is your enhancement related to a problem? Please describe.

Describe the solution you'd like

gattytto commented Nov 3, 2020 • edited Loading

benoitf commented Nov 3, 2020

ericwill commented Nov 3, 2020

l0rd commented Feb 10, 2021

nickboldt commented Feb 23, 2021

sympatheticmoose commented Feb 23, 2021

benoitf commented Feb 23, 2021

sympatheticmoose commented Feb 23, 2021

tsmaeder commented Feb 23, 2021

benoitf commented Feb 23, 2021

tsmaeder commented Feb 23, 2021

tsmaeder commented Feb 23, 2021

ericwill commented Feb 23, 2021 • edited Loading

benoitf commented Feb 23, 2021

nickboldt commented Feb 23, 2021 • edited Loading

ericwill commented Feb 23, 2021

nickboldt commented Feb 23, 2021

nickboldt commented Feb 25, 2021

Ohrimenko1988 commented Apr 21, 2021

benoitf commented Apr 22, 2021 • edited Loading

benoitf commented Nov 3, 2020 •

edited by l0rd

Loading

gattytto commented Nov 3, 2020 •

edited

Loading

ericwill commented Feb 23, 2021 •

edited

Loading

nickboldt commented Feb 23, 2021 •

edited

Loading

benoitf commented Apr 22, 2021 •

edited

Loading