Che operator olm files are mangled since 7.16.0

[nickboldt]

Comparing nightly olm file vs. 7.16.0, we see the formatting for embedded annotations has been mangled:

Also further down in the file we see another mangled formatting:

(this is comparing 7.15.2 and 7.16.0, so evidently this change happened some time after 7.15.2 was released.)

This looks to me like someone applied a yq transformation without using the yq -yY flags to preserve whitespace formatting.

[nickboldt]

I think the reason the diff generator isn't reporting this problem is that we compute the diff BEFORE running addDigests.sh:

  cp ${LAST_NIGHTLY_CRD} ${RELEASE_CRD}
  if [[ $platform == "openshift" ]]; then
    yq -riSY  '.spec.preserveUnknownFields = false' ${RELEASE_CRD}
    yq -riSY  '.spec.validation.openAPIV3Schema.type = "object"' ${RELEASE_CRD}
    eval head -10 ${LAST_NIGHTLY_CRD} | cat - ${RELEASE_CRD} > tmp && mv tmp ${RELEASE_CRD}
  fi

  sed -e "s/${lastPackagePreReleaseVersion}/${RELEASE}/" "${packageFilePath}" > "${packageFilePath}.new"
  mv "${packageFilePath}.new" "${packageFilePath}"

  diff -u ${PRE_RELEASE_CSV} ${RELEASE_CSV} > ${RELEASE_CSV}".diff" || true
  diff -u ${PRE_RELEASE_CRD} ${RELEASE_CRD} > ${RELEASE_CRD}".diff" || true
done
cd "${CURRENT_DIR}"

source ${BASE_DIR}/addDigests.sh -w ${BASE_DIR} \
                -r "eclipse-che-preview-.*\.v${RELEASE}.*yaml" \
                -t ${RELEASE}

-- https://github.com/eclipse/che-operator/blob/master/olm/release-olm-files.sh

[amisevsk]

Setting as P1 since even though it does not impact usage, it's a build issue that could bite us.