-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Che commands binding for multi-root workspaces #17191
Comments
btw: my first idea was described here #15540. Now we have ability to define |
With eclipse-che/che-theia#739 being merged, we can map commands, which are global in the devfile (relative to projects) to user-level tasks in Theia. Also, there is the action type |
In order to proceed with the general goal of enabling multi-root mapping of che workspaces, we need to solve the mapping of che command actions of type "vscode-task" and "vscode-launch". |
Issues go stale after Mark the issue as fresh with If this issue is safe to close now please do so. Moderators: Add |
Issues go stale after Mark the issue as fresh with If this issue is safe to close now please do so. Moderators: Add |
Current behavior
Configurations are exported from the
devfile
to the corresponding config file (tasks.json
orlaunch.json
) in the/workspaceFolder/.theia
directory.I think that actually
che
tasks at the moment areGlobal
tasks.For example, you have a
devfile
with two projectstheia
andche-theia
and commands to build these projects (theia:build
andche-theia:build
tasks).Both commands are available for running independently what workspace folder you open:
/projects
is a workspace folder:theia:build
andche-theia:build
tasks are available for running/theia
is a workspace folder:theia:build
andche-theia:build
tasks are still available for runningche-theia
is a workspace folder:theia:build
andche-theia:build
tasks are still available for runningPlease see more details here
But why according to our strategy
theia:build
andche-theia:build
tasks are global?Maybe it make sense that one of them should belongs to
theia
project and another one toche-theia
project. At the same time user can have global taskbuild
like:New behavior
According to the doc https://www.eclipse.org/che/docs/che-7/defining-custom-commands-for-che-theia/ there are the following types of commands:
Within current issue I would like to discuss how we should bind
Che
commands, especially taken into account that:Che
commands with typeexec
on user level (tasks configurations become trulyGlobal
)launch
configurations are going to live in the config file of/workspaceFolder/.theia
directoryThe text was updated successfully, but these errors were encountered: