Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create LogCollector component #15835

Closed
sparkoo opened this issue Jan 27, 2020 · 1 comment
Closed

Create LogCollector component #15835

sparkoo opened this issue Jan 27, 2020 · 1 comment
Labels
area/che-server kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.

Comments

@sparkoo
Copy link
Member

sparkoo commented Jan 27, 2020 •
edited
Loading

Is your enhancement related to a problem? Please describe.

After #15834, we will have container's logs in workspace PV. Now we need to collect them and provide to the persistence layer.

Describe the solution you'd like

  • Create new LogCollector component or find suitable existing solution. It should:
  • Che-server must watch on workspace exit event and start LogCollector pod, when workspace stops. Che-server must prevent starting the workspace while LogCollector pod is running and must ensure that workspace can be started again, when LogCollector do it's job.

Describe alternatives you've considered

  • collector sidecar that would watch kubectl logs -f ... on all containers
  • watch kubectl logs -f ... from che-server
  • change kube logging driver to log where we need

Additional context

#15047
@sparkoo sparkoo added the kind/enhancement A feature request - must adhere to the feature request template. label Jan 27, 2020
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 27, 2020
@sparkoo sparkoo removed the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Jan 27, 2020
@sparkoo sparkoo mentioned this issue Jan 27, 2020
Closed
@skabashnyuk skabashnyuk mentioned this issue Jan 27, 2020
Closed
12 tasks
@sparkoo sparkoo added area/che-server severity/P1 Has a major impact to usage or development of the system. team/platform labels Jan 27, 2020
@sparkoo sparkoo mentioned this issue Jan 29, 2020
Closed
@sparkoo
Copy link
Member Author

sparkoo commented Feb 11, 2020

replaced with #15983 to more details see this mailing list thread https://www.eclipse.org/lists/che-dev/msg03526.html

@sparkoo sparkoo closed this as completed Feb 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/che-server kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sparkoo @che-bot