Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC stack #15696

Closed
gattytto opened this issue Jan 15, 2020 · 5 comments
Closed

gRPC stack #15696

gattytto opened this issue Jan 15, 2020 · 5 comments
Labels
area/languages Issues related to Language extensions or plugins integration. kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system. status/in-progress This issue has been taken by an engineer and is under active development.

Comments

@gattytto
Copy link

gattytto commented Jan 15, 2020

Is your enhancement related to a problem? Please describe.

no

Describe the solution you'd like

start a gRPC/protobuf sprint to summarize status of the needed parts, since some of them are still evolving (example: Quarkus for gRPC and protobuf does not still have TLS support) and some of them are already present in che but need a bit of additional stuff to be directly usable for gRPC.

Describe alternatives you've considered

I tried asking docker base images maintainers to add some binaries to the base language containers (for instance the golang image) but was denied because those base images are as minimum as possible and strictly related to the programming language and not the external tools.

Additional context

che7 is cloud-native, and gRPC is a member of the Cloud Native Computing Fundation https://www.cncf.io/

google protobuf compiler protoc (produces grpc artifacts using the grpc plugin) uses .proto files and there's already a ms-vscode extension around it.
#15577

EDIT: ADD BAZEL TO THE MIX
protoc-gen binaries for languages have been deprecated in favor of plugin-form generators and they are implemented using bazelbuild. for base reference see this file and some other languages are being added but are not included in that project, like:
Web-Javascript that is waiting for this pr to also allow nested protobuf includes (using @ references).
Scala

WHY A STACK?

  • gRPC is language-agnostic as it is provided in many of them

  • I think it would be nice to have this in a stack because then one could re-use resources from CLI containers for specific languages (like the quarkus or golang CLI container) to have the protoc compiler building different languages code without the need to have a bloated proto3 sidecar that covers all the languages.

@gattytto gattytto added the kind/enhancement A feature request - must adhere to the feature request template. label Jan 15, 2020
@benoitf benoitf added area/stacks severity/P2 Has a minor but important impact to the usage or development of the system. labels Jan 15, 2020
@gattytto
Copy link
Author

there's also gRPC schemas generation from openAPI schemas implemented in openAPI-Generator OpenAPITools/openapi-generator#3818 and there's 4 openapi ms-vscode extensions.

@gattytto
Copy link
Author

it looks like all the protoc-gen-* are community driven and only official protoc plugin is grpc, also google found their own way of doing things for final ready-to-use client libs generation, toolset and pipeline is mentioned here OpenAPITools/openapi-generator#5096 (comment)

@che-bot
Copy link
Contributor

che-bot commented Jan 4, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 4, 2021
@ericwill ericwill added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. area/languages Issues related to Language extensions or plugins integration. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. area/stacks labels Jan 5, 2021
@gattytto gattytto added status/in-progress This issue has been taken by an engineer and is under active development. and removed lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. labels Jan 22, 2021
@che-bot
Copy link
Contributor

che-bot commented Aug 9, 2021

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 9, 2021
@svor svor removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 17, 2021
@che-bot
Copy link
Contributor

che-bot commented Feb 13, 2022

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 13, 2022
@che-bot che-bot closed this as completed Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/languages Issues related to Language extensions or plugins integration. kind/enhancement A feature request - must adhere to the feature request template. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. severity/P2 Has a minor but important impact to the usage or development of the system. status/in-progress This issue has been taken by an engineer and is under active development.
Projects
None yet
Development

No branches or pull requests

5 participants