Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow server:start to deploy a new Che even if one is already running #14474

Closed
che-bot opened this issue Sep 9, 2019 · 4 comments
Closed

Allow server:start to deploy a new Che even if one is already running #14474

che-bot opened this issue Sep 9, 2019 · 4 comments
Labels
area/chectl Issues related to chectl, the CLI of Che kind/enhancement A feature request - must adhere to the feature request template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P2 Has a minor but important impact to the usage or development of the system.
Milestone

Comments

@che-bot
Copy link
Contributor

che-bot commented Sep 9, 2019

From chectl created by AndrienkoAleksandr: che-incubator/chectl#32

It would be nice to have ability set up helm application name. It should resolve conflict in case if user want to have few CHE servers on the one Minikube. For example I used Minikube with already installed CHE. I used chectl server:start and I expected that chectl tool will create for me separated new che and I will get two CHE servers. But I've got conflict because, chectl tried to use resources from my first already installed Eclipse CHE in the another namespace, because helm application name was the same.

@che-bot
Copy link
Contributor Author

che-bot commented Sep 9, 2019

Looks good for me.

@che-bot
Copy link
Contributor Author

che-bot commented Sep 9, 2019

@AndrienkoAleksandr your scenario makes sense but I would like to avoid the flag to be helm specific because the problem here is more generic:

what server:start should do if a Che instance is already deployed: update it, create a new one or fail?

It currently updates it (with helm update) but I think a better approach would be to use a flag --if-already-exist that accepts 3 values:

  • fail (the default)
  • update (that calls chectl server:update)
  • new-instance

What do you think?

@benoitf benoitf added the area/chectl Issues related to chectl, the CLI of Che label Sep 9, 2019
@che-bot che-bot added the status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. label Sep 9, 2019
@ibuziuk ibuziuk added kind/enhancement A feature request - must adhere to the feature request template. severity/P2 Has a minor but important impact to the usage or development of the system. and removed status/need-triage An issue that needs to be prioritized by the curator responsible for the triage. See https://github. labels Sep 9, 2019
@che-bot
Copy link
Contributor Author

che-bot commented Aug 21, 2020

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

@che-bot che-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 21, 2020
@tolusha tolusha added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 21, 2020
@tolusha
Copy link
Contributor

tolusha commented Aug 25, 2020

Fixed by che-incubator/chectl@2fca137

We allows to deploy several Eclipse Che on a single cluster using --installer operator.
Every deployment will have it's own clusterrole and clusterrolebinding objects.
Besides this we check if CRD object is the same and throws an error if not.

@tolusha tolusha closed this as completed Aug 25, 2020
@tolusha tolusha added this to the 7.18 milestone Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/chectl Issues related to chectl, the CLI of Che kind/enhancement A feature request - must adhere to the feature request template. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. severity/P2 Has a minor but important impact to the usage or development of the system.
Projects
None yet
Development

No branches or pull requests

4 participants