NPE when a devfile command references theia

[RomanNikitenko]

Hello!
I had two components in my devFile and a lot of commands. I used minikube and chectl to start workspace from the devfile. My workspace was stuck every time and I couldn't understand what's the problem with my devfile.

The problem was solved when I replaced the value of the component field theia-editor by che-dev for one of the commands.

So, my question is: can I define theia-editor as component for commands?
If no, can we display some warning message for user for this case? For example, I get error:

when I just miss some letter for component field. So, maybe we can do something similar for described case.

Maybe something wrong with my devfile, please take a look (I simplified the devfile as possible and left only two commands and two components - for example):

apiVersion: 1.0.0
metadata:
 name: che
projects:
  - name: che-theia
    source:
      type: git
      location: 'https://github.com/eclipse/che-theia.git'
components:
  - 
    alias: che-dev
    type: dockerimage
    image: eclipse/che-theia-dev:next
    mountSources: true
    endpoints:
      - name: "theia-dev"
        port: 3130
        attributes:
          protocol: tcp
          public: 'true'
    memoryLimit: 4Gi
  - 
    alias: theia-editor
    reference: >-
      https://raw.githubusercontent.com/eclipse/che-plugin-registry/master/v3/plugins/eclipse/che-theia/next/meta.yaml
    type: cheEditor

commands:
- name: theia:build
  actions:
  - type: exec
    component: che-dev
    command: >
              yarn
    workdir: /projects/theia

- name: theia:run:watch
  actions:
  - type: exec
    component: theia-editor
    command: >
              yarn watch
    workdir: /projects/theia

Thanks in advance!

[skabashnyuk]

@sleshchenko @metlos thoughts?

[sleshchenko]

@RomanNikitenko

So, my question is: can I define theia-editor as component for commands?

It should work and I see no reason why we should deny it.

I debugged a workspace start with your Devfile and the reason of failing is NPE

The actual cause is hidden here https://github.com/eclipse/che/blob/f601f1652795048641001387c1ef13192f38a224/wsmaster/che-core-api-workspace/src/main/java/org/eclipse/che/api/workspace/server/wsplugins/model/ExtendedPluginFQN.java#L38

It's related to #13297

[skabashnyuk]

@rhopp @l0rd wdyt is it 7.0.0 or 7.1?

[skabashnyuk]

Fix look like not very complex

[sleshchenko]

I've created a separate issue for Workspace Loader since it has to show an error message that workspace failed to start #13846

[nickboldt]

Based on triage doc https://docs.google.com/document/d/1heR9ysCHCPxcoyQbI2er7QeMAKk2LEecjTFQayL65mA/edit# I would surmise that if this is a P1, it's for 7.1. If it's a blocker, it's for 7.0.

[l0rd]

I would say that's 7.0.0 only if it affects some commands of the devfiles in the devfile registry. Otherwise I agree with @nickboldt triage.

[l0rd]

And I have changed the title of this issue because it was really a bad one.

[sparkoo]

I'm working on this