Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chectl uses deprecated method for creating workspaces from devfile #13623

Closed
sleshchenko opened this issue Jun 24, 2019 · 2 comments · Fixed by che-incubator/chectl#202
Closed

Chectl uses deprecated method for creating workspaces from devfile #13623

sleshchenko opened this issue Jun 24, 2019 · 2 comments · Fixed by che-incubator/chectl#202
Assignees
@l0rd
Labels
area/chectl Issues related to chectl, the CLI of Che kind/enhancement A feature request - must adhere to the feature request template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.
Milestone
7.0.0

Comments

@sleshchenko
Copy link
Member

Description

After merging of the following issue the method that checlt uses (POST -> /api/devfile) for workspace creating from Devfile is going to be deprecated #13588
This method convert Devfile to WorkspaceConfig and then create a workspace with that.
It's needed to use new method in chectl POST -> /api/workspace/devfile/

Reproduction Steps

  1. Create a worspace with devfile via chectl.
  2. Open its configuration in dashboard.
    Expected: It's possible to edit workspace configuration in Devfile format.
    Actual: It's not possible to edit Devfile since workspace is actually created with converted workspace config.

OS and version:

Diagnostics:
@sleshchenko sleshchenko mentioned this issue Jun 24, 2019
Closed
@sleshchenko
Copy link
Member Author

cc @l0rd @slemeur I think it's critical for GA otherwise chectl would continue to create workspaces that will stop work later.

@l0rd
Copy link
Contributor

l0rd commented Jun 24, 2019

👍

@l0rd l0rd added kind/enhancement A feature request - must adhere to the feature request template. severity/P1 Has a major impact to usage or development of the system. target/che7GA labels Jun 25, 2019
@l0rd l0rd mentioned this issue Jun 27, 2019
Closed
85 tasks
@sleshchenko sleshchenko mentioned this issue Jun 27, 2019
Closed
@l0rd l0rd self-assigned this Jun 27, 2019
@l0rd l0rd added severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code. target/che7GA and removed severity/P1 Has a major impact to usage or development of the system. labels Jun 27, 2019
@l0rd l0rd added this to the 7.0.0 milestone Jun 27, 2019
@sunix sunix mentioned this issue Jul 3, 2019
Closed
@sunix sunix added the area/chectl Issues related to chectl, the CLI of Che label Jul 3, 2019
@l0rd l0rd mentioned this issue Jul 3, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@l0rd l0rd

Labels
area/chectl Issues related to chectl, the CLI of Che kind/enhancement A feature request - must adhere to the feature request template. severity/blocker Causes system to crash and be non-recoverable or prevents Che developers from working on Che code.
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

fix: update che API devfile endpoint l0rd/chectl
3 participants
@l0rd @sunix @sleshchenko