Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error trying to start wsagent when loading a devfile #13448

Closed
l0rd opened this issue May 30, 2019 · 2 comments · Fixed by #13462
Closed

Error trying to start wsagent when loading a devfile #13448

l0rd opened this issue May 30, 2019 · 2 comments · Fixed by #13462
Labels
kind/enhancement A feature request - must adhere to the feature request template.

Comments

@l0rd
Copy link
Contributor

l0rd commented May 30, 2019

Description

Loading a devfile as a factory in che.openshift.io

image

The workspace creation fails because there are not enough resources. And that's normal. But the message talks about the workspace agent and this is misleading since it should be a Che 7 sidecar workspace without the agents.

Reproduction Steps

https://che.openshift.io/f?url=https://pastebin.com/raw/kwhdvQQ9

@l0rd l0rd added team/platform kind/enhancement A feature request - must adhere to the feature request template. labels May 30, 2019
@skabashnyuk
Copy link
Contributor

skabashnyuk commented May 30, 2019

CC @ashumilova
This is a code responsible for this message https://github.com/eclipse/che/blob/master/dashboard/src/app/factories/load-factory/load-factory.controller.ts#L423-L425

            .title('Error when starting agent')
            .content('Unable to start workspace agent. Error when trying to start the workspace agent: ' + message.error)
            .ariaLabel('Workspace agent start')

Any suggestions about how to rephrase?

What about?

            .title('Error when starting workspace')
            .content('Unable to start workspace. Error when trying to start the workspace: ' + message.error)
            .ariaLabel('Workspace start')

@l0rd
Copy link
Contributor Author

l0rd commented May 31, 2019

@skabashnyuk 👍 for the rephrasing that you are proposing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants