Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser tab with opened WorkspaceLoader hangs when Che Server is unreachable #12063

Closed
sleshchenko opened this issue Nov 28, 2018 · 9 comments
Closed
Assignees
Labels
kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.

Comments

@sleshchenko
Copy link
Member

sleshchenko commented Nov 28, 2018

Description

Browser tab with opened WorkspaceLoader hangs when Che Server is unreachable.

To reproduce it do the following actions:

  1. Start a workspace.
  2. Scale Che Deployment down to 0 replicas while workspace is starting.
  3. Check Browser Tab: requests number grows very fast because of tries to establish WebSocket connection.
    wsloader-websocket
    Usually after some time tab is crashed or hanged completely.
    screenshot_20181128_121909

As a possible solution workspace loader should retry to establish WebSocket connection with some period like 1 second(Dashboard does something like that).

OS and version:

Diagnostics:

@sleshchenko sleshchenko added kind/bug Outline of a bug - must adhere to the bug report template. team/ide2 labels Nov 28, 2018
@garagatyi
Copy link

I also suffered from that a lot!

@monaka
Copy link
Member

monaka commented Dec 4, 2018

Same here. And I'm trying to fix for a couple of weeks. There have some unhandled promises and unsuitable recovery code. I think it should be almost re-written.

@skabashnyuk
Copy link
Contributor

Related or duplicate #12099. Talked yesterday about this issue with @ashumilova I think we need to review the way how token that uses for websocket connection can be validated on client-side. I think the cause of the current issue and #12099 are related to the expired keycloak session and invalid JWT token.

@sleshchenko
Copy link
Member Author

Related or duplicate #12099.

@skabashnyuk I think they are definitely not duplicated. Because in the case which is described by Mykola - token is expired and in the case I reported - I manually stopped Che Server (it may be crashed or updating), so used token doesn't matter, Che Server endpoints are not available.

@sleshchenko
Copy link
Member Author

Looks like it is still actual even after merging #12421 =(

@garagatyi
Copy link

Still actual. Here is screenshot with the trace of component that fires requests
image
And after just a couple of minutes it makes my PC hang, not only browser tab. I couldn't actually close the tab because it was that overloaded that browser no longer responded at all.
Just a couple of minutes that there are HUNDREDS of THOUSANDS of requests fired (see bottom left corner for the counter)
image

@garagatyi
Copy link

This is really nasty bug that can cause huge confusion for a Che user. @ashumilova since @evidolob is out of reach at the moment, could you check if your team could fix this bug? It is long-running bug that caused a lot of troubles for Che maintainers, so fixing it could improve overall performance of the contributors. Thanks!

@ashumilova
Copy link
Contributor

Added to High Priority Fixes for the next sprint plan.

@garagatyi
Copy link

Thanks! I think that @sleshchenko will be way happier when fix lends

@AndrienkoAleksandr AndrienkoAleksandr self-assigned this May 2, 2019
@AndrienkoAleksandr AndrienkoAleksandr added the status/in-progress This issue has been taken by an engineer and is under active development. label May 2, 2019
@AndrienkoAleksandr AndrienkoAleksandr added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels May 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community.
Projects
None yet
Development

No branches or pull requests

6 participants