-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Browser tab with opened WorkspaceLoader hangs when Che Server is unreachable #12063
Comments
I also suffered from that a lot! |
Same here. And I'm trying to fix for a couple of weeks. There have some unhandled promises and unsuitable recovery code. I think it should be almost re-written. |
Related or duplicate #12099. Talked yesterday about this issue with @ashumilova I think we need to review the way how token that uses for websocket connection can be validated on client-side. I think the cause of the current issue and #12099 are related to the expired keycloak session and invalid JWT token. |
@skabashnyuk I think they are definitely not duplicated. Because in the case which is described by Mykola - token is expired and in the case I reported - I manually stopped Che Server (it may be crashed or updating), so used token doesn't matter, Che Server endpoints are not available. |
Looks like it is still actual even after merging #12421 =( |
This is really nasty bug that can cause huge confusion for a Che user. @ashumilova since @evidolob is out of reach at the moment, could you check if your team could fix this bug? It is long-running bug that caused a lot of troubles for Che maintainers, so fixing it could improve overall performance of the contributors. Thanks! |
Added to High Priority Fixes for the next sprint plan. |
Thanks! I think that @sleshchenko will be way happier when fix lends |
Description
Browser tab with opened WorkspaceLoader hangs when Che Server is unreachable.
To reproduce it do the following actions:
Usually after some time tab is crashed or hanged completely.
As a possible solution workspace loader should retry to establish WebSocket connection with some period like 1 second(Dashboard does something like that).
OS and version:
Diagnostics:
The text was updated successfully, but these errors were encountered: