Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: do not allow starting a DevWorkspace if there is already one running #470

Closed
wants to merge 1 commit into from

Conversation

ibuziuk
Copy link
Member

@ibuziuk ibuziuk commented Mar 9, 2022

What does this PR do?

Do not allow starting a DevWorkspace if there is already one running

What issues does this PR fix or reference?

eclipse-che/che#21032

Based on the internal discussion, for the time being, it was decided not to add extra property similar to CHE_LIMITS_USER_WORKSPACES_RUN_COUNT since we only support the common PVC strategy, so by definition only a single running workspace is allowed for RWO volumes.

Is it tested? How?

do not  allow more workspaces

verbose

Release Notes

Docs PR

N/A

@openshift-ci
Copy link

openshift-ci bot commented Mar 9, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibuziuk

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@che-bot
Copy link
Contributor

che-bot commented Mar 9, 2022

Click here to review and test in web IDE: Contribute

@openshift-ci
Copy link

openshift-ci bot commented Mar 9, 2022

@ibuziuk: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/v8-dashboard-happy-path b760a08 link true /test v8-dashboard-happy-path

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ibuziuk ibuziuk requested a review from amisevsk March 9, 2022 15:33
@ibuziuk ibuziuk closed this Mar 9, 2022
@ibuziuk
Copy link
Member Author

ibuziuk commented Mar 9, 2022

closing in favour of #472

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants