Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Decommissioning PostgreSQL database #35

Merged
merged 1 commit into from
Mar 20, 2023
Merged

feat: Decommissioning PostgreSQL database #35

merged 1 commit into from
Mar 20, 2023

Conversation

ibuziuk
Copy link
Member

@ibuziuk ibuziuk commented Mar 13, 2023 •
edited
Loading

@ibuziuk ibuziuk force-pushed the che-21374 branch 8 times, most recently from ef01b23 to 8b44aa9 Compare March 17, 2023 13:41
@ibuziuk ibuziuk marked this pull request as ready for review March 17, 2023 13:42
@ibuziuk ibuziuk force-pushed the che-21374 branch 4 times, most recently from 65579bb to 939e8cb Compare March 17, 2023 15:02
@ibuziuk ibuziuk requested a review from l0rd March 17, 2023 15:14
@ibuziuk ibuziuk force-pushed the che-21374 branch 3 times, most recently from 7da31d7 to 77a8ecb Compare March 17, 2023 15:24
dkwon17
dkwon17 reviewed Mar 17, 2023
View reviewed changes
Copy link
Contributor

@dkwon17 dkwon17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy to understand blog post, I have some suggestions:

_posts/2023-03-20-decommissioning-postgresql-database.adoc Outdated Show resolved Hide resolved
_posts/2023-03-20-decommissioning-postgresql-database.adoc Outdated Show resolved Hide resolved
_posts/2023-03-20-decommissioning-postgresql-database.adoc Outdated Show resolved Hide resolved
_posts/2023-03-20-decommissioning-postgresql-database.adoc Outdated Show resolved Hide resolved
_posts/2023-03-20-decommissioning-postgresql-database.adoc Outdated Show resolved Hide resolved
@ibuziuk
Copy link
Member Author

ibuziuk commented Mar 17, 2023

@dkwon17 great review comments, thanks 👍

mbenitez1607
mbenitez1607 reviewed Mar 17, 2023
View reviewed changes
Copy link

@mbenitez1607 mbenitez1607 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good job!
I added some suggestions, but feel free to take only what makes sense to you :)

_posts/2023-03-20-decommissioning-postgresql-database.adoc Outdated Show resolved Hide resolved
_posts/2023-03-20-decommissioning-postgresql-database.adoc Outdated Show resolved Hide resolved
_posts/2023-03-20-decommissioning-postgresql-database.adoc Outdated Show resolved Hide resolved
_posts/2023-03-20-decommissioning-postgresql-database.adoc Outdated Show resolved Hide resolved
_posts/2023-03-20-decommissioning-postgresql-database.adoc Outdated Show resolved Hide resolved
_posts/2023-03-20-decommissioning-postgresql-database.adoc Outdated Show resolved Hide resolved
@ibuziuk ibuziuk force-pushed the che-21374 branch 7 times, most recently from b1db629 to dad23dd Compare March 20, 2023 16:05
l0rd
l0rd approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@l0rd l0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a minor comment but overall the article makes a lot of sense and is well written. Good job!

_posts/2023-03-20-decommissioning-postgresql-database.adoc Outdated Show resolved Hide resolved
@ibuziuk
Copy link
Member Author

ibuziuk commented Mar 20, 2023 •
edited
Loading

thank you for the review. merging to main

@ibuziuk ibuziuk merged commit 7d246c0 into eclipse-che:main Mar 20, 2023
@ibuziuk ibuziuk mentioned this pull request Nov 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkwon17 dkwon17 dkwon17 left review comments

@mbenitez1607 mbenitez1607 mbenitez1607 left review comments

@l0rd l0rd l0rd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ibuziuk @l0rd @mbenitez1607 @dkwon17