Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

location id should not be unique #160

Open
phermsdorf opened this issue Dec 4, 2024 · 2 comments
Open

location id should not be unique #160

phermsdorf opened this issue Dec 4, 2024 · 2 comments

Comments

@phermsdorf
Copy link

Hi,

with #17 it was possible to add an id to a repository eg. for maven authentication via. settings.xml username/password combinations.
But the repo id was added as ((ID=ID)? which to my understanding fordes it be a unique identifier.

This turns out to be a problem, because we have a nexus repo server which hosts several diferent repositories, but with the same authentication credentials.

So writing something like this in the target file is basically perfectly fine and works:

    <location includeMode="slicer" includeAllPlatforms="false" includeSource="true" includeConfigurePhase="false" type="InstallableUnit">
      <unit id="com.myfeature1.feature.group" version="4.20.1"/>
      <repository id="myrepo-id" location="http://repo.intern/p2/repo1"/>
    </location>
    <location includeMode="slicer" includeAllPlatforms="false" includeSource="true" includeConfigurePhase="false" type="InstallableUnit">
      <unit id="org.feature2.feature.group" version="1.2.3"/>
      <repository id="myrepo-id" location="http://repo.intern/p2/repo2"/>
    </location>

But it's not possible to generate that from a .tpd file, because the editor claims the myrepo-id to be unique.

I could try to propose a pull request, if someone is willing to look at it.
Thank you.

Bye Peter

@phermsdorf
Copy link
Author

We now moved to the newest Eclipse and Tycho which supports version ranges of artifacts directly in the target file. So this issue is no longer important for us.

Feel free to close or keep open for reference....

Bye Peter

@merks
Copy link
Contributor

merks commented Dec 12, 2024

I don't think I saw this issue come by until you most recent comment; it could be too much mail coming all the time...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants