Add native runtime hints for weaver-messages #227
Comments
|
@aclement, please take a look at this. I know that you are part of the Spring Native team, so you probably know what this is about. I have no idea about GraalVM, never used it before and do not even know what a "native hint" is supposed to be. Pointers: This is the corresponding properties file. |
@d-eder, AspectJ does not provide any special builds for GraalVM. Can you please explain what a "native hint" is meant to be and how AspectJ could be enhanced to provide one? I cannot do anything, if I do not understand what you are even asking of me. The person I assigned this issue to is unresponsive, so I cannot ask him either. Please explain and/or provide a PR. |
|
@d-eder, CC @mp911de, @Ricard-Kollcaku: I have zero GraalVM experience, like I said before. I asked a question, which I got no response to:
This issue is not going to magically solve itself by throwing something over the fence. Please tell me what exactly you need AspectJ to provide or create a PR. I have no intention of ignoring issues, but if Spring refuses to do something about it, arguing that AspectJ should, nothing will happen if I do not know what is expected from us here. Probably @aclement would know, as he knows GraalVM, but he has not been active in the project for quite a while. Thanks in advance to anyone who can she light on this matter. |
|
Hi @kriegaex regarding my ticket this is resolved by spring boot team. Hints are declaration that u do to graalvm when your code uses some classes for reflection (proxy, resources) things that graalvm cant detect in compile time. |
|
Thanks, @Ricard-Kollcaku. That does not help me much with regard to what exactly, if anything, I am expected to add to AspectJ to make it work out of the box. Are you saying, this issue can be closed, or would it be better to solve this in AspectJ to get rid of any Spring workarounds? I really have no clue and also not enough time to study this topic in depth. For a little while, I am going to wait for more feedback from everyone involved here before closing the issue as "won't fix", so everybody can speak up. |
|
Sorry for the very late reply. When I find more time, I'll give it another try with updated versions. You can check Spring GraalVM Native - Image Support and/or the GraalVM Page itself to get more information and knowledge about that. What we would need is to inlcude the resource metadata similar to here. Afaik we can add this somehow to this project (probably we need to add it somewhere to the classpath) or we can use the graalvm-reachability-metadata repo. But maybe let's first evaluate, if it's still necessary and try to make it reproduceable. |
|
@d-eder, like I said, I neither have time not feel much inclined to dig into the GraalVM docs and learn everything from scratch there. So thanks, but I would really appreciate a PR in this case. At the very least, I need whatever config files need to be added to AspectJ and an exact descriptions in which artifacts they are expected to reside where. Then, I can help with any packaging or build integration issues. |
|
I quickly retested it and it seems to work now:
|
When AOP is failing due to an exception on native applications, an exception is thrown that it cannot find the resources for
org.aspectj.weaver.weaver-messages(see stacktrace).According to my MR on spring boot, we should provide native hints directly on the library or on the GraalVM repo.
Testing environment
The text was updated successfully, but these errors were encountered: