refactor(services): Use custom sorting for packages query #2129
+111
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow sorting packages by identifier, purl and the processed declared license SPDX expression. This will provide needed sorting options to allow sorting the packages table in the UI. Signed-off-by: Johanna Lamppu <[email protected]>
lamppu
requested review from
bs-ondem,
MarcelBochtler,
mnonnenmacher,
nnobelis,
oheger-bosch,
sschuberth and
wkl3nk
as code owners
lamppu
commented
Feb 27, 2025
Comment on lines
+59
to
+64
| "identifier" -> { | ||
| orders += IdentifiersTable.type to sortOrder | ||
| orders += IdentifiersTable.namespace to sortOrder | ||
| orders += IdentifiersTable.name to sortOrder | ||
| orders += IdentifiersTable.version to sortOrder | ||
| } |
There was a problem hiding this comment.
I wasn't sure if this kind of combination would be ok to use, but this is technically what we need right now in the frontend, but of course this could be separated like here, and just use a combination of those in the request from the frontend. I think I'll align these based on what would be the preferred way.
There was a problem hiding this comment.
To me the question is what's needed by the frontend, but this should be the same for the packages and the vulnerabilities table. So does the vulnerabilities table actually use the flexibility to sort by the identifier properties separately?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow sorting packages by identifier, purl and the processed declared license SPDX expression. This will provide needed sorting options to allow sorting the packages table in the UI.