-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Part 2 Classes #15
Comments
I think it makes sense to add the Part 2 models in AAS4J since it fits the goal of providing the common models. I would be in favor of putting them in a 'model-api' project to keep a separation between Part 1 & Part 2. However, there are two open points:
What do the others think? |
I agree with @FrankSchnicke that we should include de-/serialization, however, this is rather complex task as there are multiple serialization formats and parameters. Considering the amount of work this requires I would propose to handle it as a separate work package starting after we finished updating Part 1. |
Completely agreed, especially the different format variations, though only affecting JSON at the moment, give me a lot of headache. |
I have an ontology and shall files for all classes available in a private branch already, so this wouldn't be a showstopper for us.
True, we would at least need one JSON Schema file for them. Anyone knows if there is a OpenAPI-to-JSON-Schema translator out there? I have used ones for the other way (JSON Schema file to OpenAPI classes) already but never in this direction. |
Note, as discussed, we decided that this ticket is relevant for V.1.0.0. |
Progress is part of sap-contributions#3 |
Closed by #161 |
The
model
currently contains only the classes of the AAS metamodel (aka. Part 1) but the API (aka. Part 2) also introduces further classes. One example are theDescriptors
for the registry endpoints. I think it's reasonable to also include the Part 2 classes in this repo, maybe as another module (model-api-classes
?) or directly in the currentmodel
project.The text was updated successfully, but these errors were encountered: