Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more than one DataSpecificationContent #14

Closed
sebbader opened this issue Jul 25, 2022 · 6 comments
Closed

Enable more than one DataSpecificationContent #14

sebbader opened this issue Jul 25, 2022 · 6 comments
Assignees
Labels
3.0 Final AAS V3 Final Release V.1.1.0 Final Release V.1.1.0 incl. additional features

Comments

@sebbader
Copy link

sebbader commented Jul 25, 2022

c116cf7 contains a working version for DataSpecificationIEC61360. However, were is already one other mentioned DataSpecificationTemplate in the specifications, namely DataSpecificationPhysicalUnit.

There are two options how to tackle this:

  1. Create (recreate?) custom Deserialisers for DataSpecificationContent
  2. Require an attribute similar to modelType in the schemas
@sebbader-sap
Copy link
Contributor

I am in favour of option 1 as there won't be many DataSpecificationTemplates coming and a metamodel extension/extension of the schemas is not very realistic on short-notice.

@mjacoby
Copy link
Contributor

mjacoby commented Aug 8, 2022

The original implementation did support different DataSpecificationTemplates through the patter

 "embeddedDataSpecifications": [
         "embeddedDataSpecifications": {...},	// reference indicating the type
         "dataSpecificationContent": {...}		// actual data specification
     ]

However, the issue here is that in the future, eiter embeddedDataSpecifications or dataSpecificationContent but never both. So we need a way to encode the type information of the used DataSpecificationTemplate. This is currently not defined in the specification.

From my perspective, adding a modelType property would be a suitable approach consistent with the general concepts of de-/serialization. Not 100% sure how this will affect implementation but I guess it should not be to hard to implement.
Nevertheless, we should wait for standardization before starting implementation.

@sebbader-sap
Copy link
Contributor

Updating the discussion as the V3.0RC02 has been released:
dataSpecificationContent has a modelType attribute now in JSON.

This means that we now have a stable pattern to implement as soon as the other, more important tasks for the V3.0RC02 migration have been solved.

@twebermartins twebermartins moved this to 🆕 New in Eclipse AAS4J Dev Oct 24, 2022
@twebermartins twebermartins moved this from 🆕 New to 📋 Backlog in Eclipse AAS4J Dev Jan 10, 2023
@twebermartins twebermartins moved this from 📋 Backlog to 🆕 New in Eclipse AAS4J Dev Jan 10, 2023
@twebermartins twebermartins added 3.0 Final AAS V3 Final Release V.1.0.0 Final Release V.1.0.0 following EF processes labels Jun 5, 2023
@sebbader-sap sebbader-sap moved this from 🆕 New to 🏗 In progress in Eclipse AAS4J Dev Jun 22, 2023
@sebbader-sap
Copy link
Contributor

Another update from the V3.0 schemas: There is only one DataSpecificationContent now: https://github.com/admin-shell-io/aas-specs/blob/e3a0798c2fb8b2bbacef76eede663f16045bd63f/schemas/json/aas.json#L356

Means, our current approach is correct for now just because there is no other candidate for "embeddedDataSpecifications/dataSpecificationContent" at the moment. Still, we should support the generic case but the importance - with this in mind - has changed from showstopper to good to have...

@FrankSchnicke
Copy link
Contributor

Result of Committer Meeting today:

  • This is a feature that we would like to include in V1.1 but not in V1
  • In consequence, we should ensure that the current setup allows later modification without breaking changes

@FrankSchnicke FrankSchnicke added V.1.1.0 Final Release V.1.1.0 incl. additional features and removed V.1.0.0 Final Release V.1.0.0 following EF processes labels Nov 7, 2023
@FrankSchnicke FrankSchnicke moved this from 🏗 In progress to 📋 Backlog in Eclipse AAS4J Dev Nov 7, 2023
@twebermartins twebermartins moved this from 📋 Backlog to 👀 In review in Eclipse AAS4J Dev Nov 21, 2023
@FrankSchnicke
Copy link
Contributor

Closed by #207

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Eclipse AAS4J Dev Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.0 Final AAS V3 Final Release V.1.1.0 Final Release V.1.1.0 incl. additional features
Projects
Status: Done
Development

No branches or pull requests

5 participants