Replies: 2 comments 2 replies
-
Yep, I agree with both of these changes. The "MiniPickPrompt" I tried to match the style of "FloatTitle": if in color scheme it has the same background as "NormalFloat", then so should be a "MiniPickPrompt". This is the case at least in 'everforest', so makes sense to adjust "MiniPickPrompt". The "MiniFilesFile" one I simply missed when playtesting before making PRs. Yes, ideally it should not define background. (I must have been starting to feel exhaustion at this point when making all those color scheme PRs 😅) |
Beta Was this translation helpful? Give feedback.
-
That was an epic effort, covering all the themes I use! |
Beta Was this translation helpful? Give feedback.
-
While my primary themes are all mini.hues, I did spend yesterday (I'm on vacation this week) tuning all four of sainnhe's colorschemes (Everforest, Gruvbox-Material, Edge, and Sonokai) to my liking as secondaries themes. In doing so, I noticed a two mini highlight groups that need tweaking in all four themes. Specifically,
MiniPickPrompt
andMiniFilesFile
.I was going to submit PRs to the projects for all four, but I thought it might be a good idea to confirm with you if you had any other tweaks you were planning that these could be queued up with so as to not overwhelm the maintainer. Obviously, I've already fixed these in my configurations, but wanted to make sure other mini users had a good experience out-of-the-box so to speak if they use those themes.
MiniPickPrompt
does not blend with the background of the float:MiniFilesFile
does not look right if the cursor line is enabled:My fixes for both:
Beta Was this translation helpful? Give feedback.
All reactions