Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroll conflicted with browser native #47

Closed
wujie520303 opened this issue Jun 2, 2016 · 2 comments
Closed

scroll conflicted with browser native #47

wujie520303 opened this issue Jun 2, 2016 · 2 comments

Comments

@wujie520303
Copy link

when I used ng-scrollable into a popup layer with angular plugins of ng-pageslide. firstly, I found the function of ng-scrollable isn't active, untill i resized the window or the pop element wrapper. secondly, when I scroll element of popup layer, I found if the body's content has scrollbar, both of them will trigger 'scroll' action.

@echa
Copy link
Owner

echa commented Jun 2, 2016

Thanks for reporting.

Your first problem is related to #16 and a #44 is a pending pull request which I still need to work in. For now you can use the workaround described in #16 .

The scroll propagation issue is related to #27 and #42. In the latest release ngScrollable does not cancel scroll events when the scroll position is already at the content edge. Some folks felt scrolling is more natural when delegated to the outside container (e.g. the body). In your case it seems a config option to disable event propagation alltogether is the best choice. I'm working on that too.

@echa
Copy link
Owner

echa commented Apr 22, 2017

While re-reading your description I got the impression I misunderstood the second part. If this is still important to you, can you make a stripped-down example showing your second problem(on jsfiddle or somewhere else?

After my latest changes ng-scrollable compiles before the container content which should solve at least your first problem.

@echa echa closed this as completed Apr 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants