ci: use FAST_FORWARD_TOKEN to query api in fast-forward.yml #3137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without that it did not work on the test-org. See https://github.com/bacluc-test-org/ecamp3/blob/64fa2aeec519ad9b6a9d62c218e68aa31a87383a/.github/workflows/fast-forward.yml#L35 Issue: ecamp#3135
|
Sorry, colossal fail by me. |
1 similar comment
usu
approved these changes
Nov 5, 2022
There was a problem hiding this comment.
🤣 okee, I didn't thought about checking the code line-by-line
I noticed that the secret was never used, but didn't thought much more as it was only used during the actual fast-forward merge (which never happened...)
Happy if this solves it.
But I'd say not fail to you but fail to Github API docu. Not nice to have an undocumented property that then changes values based on who sends the query.
carlobeltrame
approved these changes
Nov 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without that it did not work on the test-org.
See https://github.com/bacluc-test-org/ecamp3/blob/64fa2aeec519ad9b6a9d62c218e68aa31a87383a/.github/workflows/fast-forward.yml#L35
Issue: #3135