Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement hash checksum validation functions in taquito #95

Closed
7 tasks
carte7000 opened this issue Sep 19, 2019 · 2 comments · Fixed by #1309
Closed
7 tasks

Implement hash checksum validation functions in taquito #95

carte7000 opened this issue Sep 19, 2019 · 2 comments · Fixed by #1309
Assignees
Labels
ga_release Work to be done so we can remove the beta dsignation
Milestone

Comments

@carte7000
Copy link
Contributor

carte7000 commented Sep 19, 2019

Validate hashes that have checksums and avoid making HTTP calls when we can determine that the parameters are invalid.

Addresses, block hashes, and so forth have a checksum. We intend to add support to validate locally. (We are currently deferring such validation to the node.) By supporting this validation within the library, we can give end-users and developers a better experience by detecting problems or input errors earlier.

Acceptance criteria:

  • Implement a validation function that checks:
    • [x ] Addresses (Link to utility method here)' - Already DONE
    • [x ] Chain - Already DONE
    • Operation Hash
    • Block Hash
    • Protocol Hash
    • ??? Do we need any other items to be added here?

ToDo:

  • List all hashes that can be validated.
  • Make sure each one has a method (add to the list below)
  • Make sure each one has documentation

See: https://tezostaquito.io/docs/validators

@jevonearth jevonearth changed the title Better validation for high level function Hash checksum validation in taquito Nov 1, 2019
@jevonearth jevonearth added the ga_release Work to be done so we can remove the beta dsignation label Nov 1, 2019
@jevonearth jevonearth added this to the December-2019 milestone Dec 16, 2019
@carte7000
Copy link
Contributor Author

#211 Include checksum validation for parameter encoding but not for regular transfer/delegation/origination address

@Innkst Innkst removed this from the December-2019 milestone Nov 13, 2020
@Innkst Innkst added this to the v8.2 milestone Mar 16, 2021
@Innkst Innkst modified the milestones: v10.2, v10.1 Jun 17, 2021
@Innkst Innkst modified the milestones: v10.2, v10.3 Sep 9, 2021
@roxaneletourneau roxaneletourneau modified the milestones: v11.1, v11.2 Dec 8, 2021
@dsawali dsawali self-assigned this Jan 10, 2022
@dsawali dsawali linked a pull request Jan 12, 2022 that will close this issue
6 tasks
@Innkst Innkst changed the title Hash checksum validation in taquito Implement hash checksum validation functions in taquito Jan 14, 2022
@Innkst
Copy link
Contributor

Innkst commented Jan 14, 2022

Could we please have a quick check if there are any more hashes that are not listed to be validated as well - see the last acceptance criteria. thanks!

@ac10n ac10n moved this to Done in Taquito Dev Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ga_release Work to be done so we can remove the beta dsignation
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants