Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OperationMetadataBalanceUpdates vs. OperationBalanceUpdatesItem in @taquito 19 #2817

Closed
psmolinsky opened this issue Feb 6, 2024 · 1 comment · Fixed by #2829
Closed

OperationMetadataBalanceUpdates vs. OperationBalanceUpdatesItem in @taquito 19 #2817

psmolinsky opened this issue Feb 6, 2024 · 1 comment · Fixed by #2829
Assignees
@hui-an-yang
Labels
bug Something isn't working
Milestone
v19.1

Comments

@psmolinsky
Copy link

Description
There are two different types OperationMetadataBalanceUpdates vs. OperationBalanceUpdatesItem in @taquito/rpc. They got quite inconsistent (have different fields) especially in v19 for Oxford protocol. Especially bond_id has conflicting type string vs. BondId. However, RPC schema has only single/same schema for balance updates.
@psmolinsky psmolinsky added the bug Something isn't working label Feb 6, 2024
@hui-an-yang hui-an-yang added this to the v19.1 milestone Feb 13, 2024
@hui-an-yang hui-an-yang linked a pull request Feb 15, 2024 that will close this issue
2816 update and export types #2829
Merged
9 tasks
@hui-an-yang hui-an-yang self-assigned this Feb 15, 2024
@hui-an-yang
Copy link
Collaborator

hello @psmolinsky

Thank you for reporting this. I have merged pr2816 to fix this. We decided to removed OperationBalanceUpdatesItem and use OperationMetadataBalanceUpdates for better maintenance. This will be included in the next release, in the mean time you can use preview build like this
npm i @taquito/[email protected] --registry https://npm.preview.tezostaquito.io/

@psmolinsky psmolinsky mentioned this issue May 22, 2024
Closed
@ac10n ac10n moved this to Done in Taquito Dev Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hui-an-yang hui-an-yang

Labels
bug Something isn't working
Projects
Taquito Dev
Status: Done
Milestone
v19.1
Development

Successfully merging a pull request may close this issue.

2816 update and export types ecadlabs/taquito
2 participants
@psmolinsky @hui-an-yang