Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support stake, unstake, and finalize_unstake pseudo operations in Taquito #2608

Closed
dsawali opened this issue Aug 17, 2023 · 0 comments
Closed
Milestone

Comments

@dsawali
Copy link
Contributor

dsawali commented Aug 17, 2023

Protocol Oxford will bring forth a feature flag, that when enabled, will allow users to perform stake, unstake, and finalize_unstake pseudo operations on implicit accounts.

Support the 3 pseudo operations in Taquito Contract API.

Implementation Details

Stake, unstake, and finalize_unstake are all considered 'pseudo operations' because they are essentially an extension of the existing transaction operation.

Refer to this document for further details on what that means: https://hackmd.io/@dsawali/H1_vK4t33

Implement a method wrapper in contract API similar to contractCall or setDelegate and registerDelegate. The work will encompass these domains:

  • Prepare provider
  • RPC contract provider
  • Estimate provider
  • Local forger

The method wrappers should be callable via the contract API as such:

await Tezos.contract.stake(...);

await Tezos.contract.unstake(...);

await Tezos.contract.finalizeUnstake(...);

note: same application for estimate, and prepare provider

The same goes for wallet API (but need verification on this).

Testing

Write appropriate unit and integration tests. This will be part of the ticket's acceptance criteria.

@dsawali dsawali added the oxford label Aug 17, 2023
@dsawali dsawali added this to the v18 milestone Aug 17, 2023
@dsawali dsawali added the 8 label Aug 24, 2023
@ac10n ac10n self-assigned this Aug 31, 2023
This was referenced Sep 14, 2023
@ac10n ac10n removed their assignment Apr 29, 2024
@dsawali dsawali closed this as completed May 6, 2024
@ac10n ac10n moved this to Done in Taquito Dev Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants