Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verifySignature with invalid message #2578

Closed
nurs-jubatyrov opened this issue Jul 20, 2023 · 3 comments
Closed

verifySignature with invalid message #2578

nurs-jubatyrov opened this issue Jul 20, 2023 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@nurs-jubatyrov
Copy link

When calling verifySignature you can append any character to the message payload and it would verify the signature correctly.

Steps To Reproduce
Steps to reproduce the behavior:

  1. Call verifySignature with argument and append any character to the message payload.
  2. The function should return false instead of true.

Additional context
The issue is in hex2buf function in https://github.com/ecadlabs/taquito/blob/27f57de79ab464b7c4d9255275c2f48216214fad/packages/taquito-utils/src/taquito-utils.ts#L199C3-L199C3 which would truncate if the length of the message is odd.

@nurs-jubatyrov nurs-jubatyrov added the bug Something isn't working label Jul 20, 2023
@jevonearth
Copy link
Collaborator

Acking this issue, thank you for reporting. A fix is in the works.

@jevonearth
Copy link
Collaborator

Addressed in PR #2580

@Innkst Innkst added this to the v17.1.1 milestone Jul 26, 2023
@dsawali
Copy link
Contributor

dsawali commented Jul 26, 2023

issue #2580 has been completed and the patch release Taquito v17.1.1 has been released here:
https://www.npmjs.com/package/@taquito/taquito/v/17.1.1

@dsawali dsawali closed this as completed Jul 26, 2023
@ac10n ac10n moved this to Done in Taquito Dev Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

4 participants