From 5a686281854f107257883638c72ed04ffd70160c Mon Sep 17 00:00:00 2001 From: huianyang Date: Tue, 22 Nov 2022 15:12:46 -0800 Subject: [PATCH] fix: address comments to remove kathcases integration tests re #2065 --- integration-tests/local-forging.spec.ts | 16 +--------------- .../test/taquito-local-forging.spec.ts | 11 ----------- 2 files changed, 1 insertion(+), 26 deletions(-) diff --git a/integration-tests/local-forging.spec.ts b/integration-tests/local-forging.spec.ts index 1b284c6e35..bdcfa22822 100644 --- a/integration-tests/local-forging.spec.ts +++ b/integration-tests/local-forging.spec.ts @@ -1,11 +1,10 @@ import { CONFIGS } from "./config"; -import { commonCases, kathmanduCases, limaCases } from './data/allTestsCases'; +import { commonCases, limaCases } from './data/allTestsCases'; import { LocalForger, ProtocolsHash } from '@taquito/local-forging' import { Protocols, TezosToolkit } from "@taquito/taquito"; CONFIGS().forEach(({ rpc, protocol }) => { const Tezos = new TezosToolkit(rpc); - const kathmandunet = protocol === Protocols.PtKathman ? test: test.skip; const limanetAndAlpha = protocol === Protocols.PtLimaPtL || protocol === Protocols.ProtoALpha ? test: test.skip; describe(`Test local forger: ${rpc}`, () => { @@ -25,19 +24,6 @@ CONFIGS().forEach(({ rpc, protocol }) => { }); }); - kathmanduCases.forEach(({ name, operation, expected }) => { - kathmandunet(`Should give the same result as when forging with the rpc: ${name} (${rpc})`, async done => { - const localForger = new LocalForger(protocol as unknown as ProtocolsHash); - - const result = await localForger.forge(operation); - const rpcResult = await Tezos.rpc.forgeOperations(operation); - expect(result).toEqual(rpcResult); - expect(await localForger.parse(result)).toEqual(expected || operation); - - done(); - }); - }); - limaCases.forEach(({ name, operation, expected }) => { limanetAndAlpha(`Should give the same result as when forging with the rpc: ${name} (${rpc})`, async done => { const localForger = new LocalForger(protocol as unknown as ProtocolsHash); diff --git a/packages/taquito-local-forging/test/taquito-local-forging.spec.ts b/packages/taquito-local-forging/test/taquito-local-forging.spec.ts index e6249bf87e..2ef05d9d51 100644 --- a/packages/taquito-local-forging/test/taquito-local-forging.spec.ts +++ b/packages/taquito-local-forging/test/taquito-local-forging.spec.ts @@ -31,17 +31,6 @@ describe('Forge and parse operations default protocol', () => { }); }); - // describe('Forge and parse operations kathmandu protocol', () => { - // const localForger = new LocalForger(); - // kathmanduCases.forEach(({ name, operation, expected }) => { - // test(`Common test: ${name}`, async (done) => { - // const result = await localForger.forge(operation); - // expect(await localForger.parse(result)).toEqual(expected || operation); - // done(); - // }); - // }); - // }); - describe('Forge should validate parameters against the schema', () => { const hexToParse = `0572cbea904d67468808c8eb50a9450c9721db309128012543902d0ac358a62ae28f75bb8f1c7c42c39a8c5529bf0f4e166a9d8cabc673a322fda673779d8e3822ba3ecb8670e461f73bb9021d5fd76a4c56d9d4cd16bd1bba86881979749d28`;