Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus metrics #29

Closed
jevonearth opened this issue Jun 18, 2019 · 5 comments
Closed

Prometheus metrics #29

jevonearth opened this issue Jun 18, 2019 · 5 comments
Labels
enhancement New feature or request
Milestone

Comments

@jevonearth
Copy link
Contributor

Counters and histograms for;

  • signing operations
  • labels
    • vault
    • vault_name
    • op
    • opkind
  • errors
    • backend error types (azure, use http codes? 401,403 etc...)

Create a companion grafana dashboard to help operators make the most of these metrics easily
Documentation on use, prometheus quickstart config snippets

@jevonearth jevonearth added the enhancement New feature or request label Jun 18, 2019
@jevonearth jevonearth added this to the v1.0 milestone Nov 16, 2020
@AbineshECAD AbineshECAD self-assigned this May 26, 2022
@AbineshECAD
Copy link
Contributor

@AbineshECAD Test and close if works as specified.

@jevonearth
Copy link
Contributor Author

We have a metric in "0.3.0-beta-rc1" names vault_sign_request_duration_milliseconds_bucket

Labels present;

  • vault
  • vault_name

Let's evaluate switching from histogram to summaries.

TODO:
Metrics for;

  • vault errors
  • Signatory signing requests
    • labels;
      • signatory response code (2xx, 4xx, 5xx)
      • signatory duration round trip
      • operation type & kind
      • chain_id
      • (possibly) protocol hash (short)

@michaelkernaghan
Copy link
Contributor

superseded more recent tickets. eg #306

@stephengaudet
Copy link
Contributor

signatory response code (2xx, 4xx, 5xx)
--done with #306

signatory duration round trip
--to do, currently only exposing vault time, need time between signatory receipt of request and send of response

operation type & kind
--done

chain_id
-- can be added as a label on existing metrics

(possibly) protocol hash (short)
-- can be added as a label on existing metrics

@stephengaudet stephengaudet removed their assignment Sep 12, 2023
@jevonearth
Copy link
Contributor Author

Closing as done.

signatory duration round trip - we don't have a strong need for this metric, so we will remove it from the scope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

4 participants